Evaluate and cache text sections properly

[daffl]

This pull request fixes #1065. Caching was done under the assumption that in a text sub section all expressions contain the same content making a simple template like the following fail:

<h2 class="{{#shown}}foo{{/if}} test {{#shown}}bar{{/shown}}"></h2>

The solution is to cache the evaluators for normal property lookups (like {{style}}) to improve performance but always create the evaluator when the mode is set (which means that there potentially is a different subsection).

[justinbmeyer]

Don't remove it if it kills performance. Let's figure out a way to keep it he same.

Sent from my iPhone

On Jun 12, 2014, at 5:11 PM, David Luecke notifications@github.com wrote:

This pull request removes the the evaluator caching for text section from can.stache which fixes the original issue #1065. Caching was done under the assumption that in a text sub section all expressions contain the same content making a simple template like the following fail:

The only solution I could find was removing the evaluator caching which does slow down performance for the visual benchmark.

You can merge this Pull Request by running

git pull https://github.com/bitovi/canjs stache-truthy-attributes-1065
Or view, comment on, or merge it at:

#1083

Commit Summary

Adding tests for truthy stache attributes (#1065).
Removing scope.__cache and updating test for #1065.
File Changes

M view/scope/scope.js (1)
M view/stache/mustache_core.js (9)
M view/stache/stache_test.js (12)
Patch Links:

https://github.com/bitovi/canjs/pull/1083.patch
https://github.com/bitovi/canjs/pull/1083.diff
—
Reply to this email directly or view it on GitHub.

[daffl]

I just realized that we actually can cache normal property lookups (that don't have the mode set). Fixes the test and keeps the spinning circle performance the same as before.

[justinbmeyer]

Thanks!

Sent from my iPhone

On Jun 12, 2014, at 6:35 PM, David Luecke notifications@github.com wrote:

I just realized that we actually can cache normal property lookups (that don't have the mode set). Fixes the test and keeps the spinning circle performance the same as before :-)

—
Reply to this email directly or view it on GitHub.