Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(guides): Comparison - section comparing CanJS with RxJS (observables) #2711

Merged
merged 1 commit into from Mar 5, 2019

Conversation

BigAB
Copy link
Contributor

@BigAB BigAB commented Nov 9, 2016

Part of #2679

@BigAB
Copy link
Contributor Author

BigAB commented Mar 5, 2019

Well, I don't think this is going to get merged anymore.

...also the examples are out of date. maybe next time.

@BigAB BigAB closed this Mar 5, 2019
@justinbmeyer justinbmeyer reopened this Mar 5, 2019
@justinbmeyer
Copy link
Contributor

We still plan to get an updated version in.

@BigAB
Copy link
Contributor Author

BigAB commented Mar 5, 2019

You see the date on this right?

Does this pull request bring you joy?
If you answer yes, you keep it open.

If you hesitate or say no, thank it for the service it has provided, then close it.

@justinbmeyer
Copy link
Contributor

Yes. Maybe I like pain.

@chasenlehara
Copy link
Member

I’m merging this as-is because we’re not linking to the comparison page from anywhere and this can help the next person who works on that page.

@chasenlehara chasenlehara merged commit 7c323d1 into master Mar 5, 2019
@chasenlehara chasenlehara deleted the docs-rx-vs-can branch March 5, 2019 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants