New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change name to id #3027

Merged

chasenlehara merged 1 commit into master from fix-namedLink

Mar 1, 2017

Contributor

rlin415 commented Feb 28, 2017

The "name" attribute is deprecated. It was causing this issue: canjs/bit-docs-html-canjs#208.


          change name to id

951c232

rlin415 requested a review from chasenlehara

February 28, 2017 19:17

kylegifford added the in progress label

Contributor

matthewp commented Feb 28, 2017

I don't doubt you, but could you like to anything about name being deprecated? I wasn't aware of that.

Contributor Author

rlin415 commented Feb 28, 2017

Sure! Here is one: https://www.w3schools.com/tags/att_a_name.asp

Contributor Author

rlin415 commented Feb 28, 2017

It's also stated here as well: https://www.w3.org/TR/html5/obsolete.html

Member

chasenlehara commented Feb 28, 2017

Heh, I missed the memo that name was deprecated too.

Here’s our code that doesn’t support name: https://github.com/canjs/bit-docs-html-canjs/blob/d1352069818e053453a5f082fad68e08f79f3ad6/static/canjs.js#L98

Member

chasenlehara commented Feb 28, 2017

This document will need to be updated to not use name: https://github.com/donejs/donejs/pull/829/files#diff-54741d26fa44ca37b832eee981ddc15b

chasenlehara merged commit cccff38 into master

chasenlehara deleted the fix-namedLink branch

March 1, 2017 01:47

chasenlehara removed the in progress label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet