Adds the can/es module for tree-shaking bundlers #4085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds a new module, `can/es` which exports everything from
__core__ as named exports. This enables people to import only the parts
of CanJS they need:
```js
import { Component, DefineMap } from "can/es";
```
Provided they use a tree-shaking capable bundler, the bundle size will
not be too large.
Closes #4013
Merged
|
|
||
| ## Names | ||
|
|
||
| The names that can be exported by this module mirror what is part of the `can` namespace object that you get from `import can from "can"`. You can see the names that `can/es` exports [here](https://github.com/canjs/canjs/blob/master/es.js). |
There was a problem hiding this comment.
should this be
The names that can be imported from this module...
or
The names that are exported by this module...
There was a problem hiding this comment.
I'll go with the former.
phillipskevin
approved these changes
Apr 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds a new module,
can/eswhich exports everything fromcore as named exports. This enables people to import only the parts
of CanJS they need:
Provided they use a tree-shaking capable bundler, the bundle size will
not be too large.
Closes #4013