#713 cleanup can.Control, fixup contributing guide #746
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,18 @@ | |||
| @function can.Control.prototype.init init | |||
There was a problem hiding this comment.
I think the better place for this would be directly in https://github.com/bitovi/canjs/blob/master/control/control.js.
|
Ah...... So this's how to build the docs. |
daffl
added a commit
that referenced
this pull request
Feb 25, 2014
#713 cleanup can.Control, fixup contributing guide
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#713 proposed solution. cleaned up can.Control docs to remove some noise and be more explicit in the main example. Also fixed up the contributing guide so it has working instructions for generating the docs, and renders command lines correctly.