Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pydantic 2 version not always including charm source #1812

Closed
lengau opened this issue Aug 14, 2024 · 3 comments
Closed

pydantic 2 version not always including charm source #1812

lengau opened this issue Aug 14, 2024 · 3 comments
Assignees
Labels
Bug Something isn't working triaged

Comments

@lengau
Copy link
Collaborator

lengau commented Aug 14, 2024

Bug Description

the pydantic 2 release sometimes just includes metadata. Seems to happen for bases charms but not platforms ones

To Reproduce

Run spread tests

Environment

n/a

charmcraft.yaml

n/a

Relevant log output

2024-08-14 14:58:29 Error executing multipass:ubuntu-22.04-64:tests/spread/smoketests/basic:jammy_bases (multipass:ubuntu-22.04-64) : 
-----
+ cd charm
+ charmcraft pack --verbose
2024-08-14 14:57:54.271 Starting charmcraft, version 3.1.1.post65+g70078b0
2024-08-14 14:57:54.271 Logging execution to '/root/.local/state/charmcraft/log/charmcraft-20240814-145754.270839.log'
2024-08-14 14:57:54.271 Log verbosity level set to DEBUG
Starting charmcraft, version 3.1.1.post65+g70078b0
Logging execution to '/root/.local/state/charmcraft/log/charmcraft-20240814-145754.270839.log'
Launching managed ubuntu 22.04 instance...
Creating instance from base instance
Starting instance
Starting charmcraft, version 3.1.1.post65+g70078b0
Logging execution to '/tmp/charmcraft.log'
Starting charmcraft, version 3.1.1.post65+g70078b0
Logging execution to '/tmp/charmcraft.log'
Initialising lifecycle
Installing build-packages
Packing...
Packing charm jammy_ubuntu-22.04-amd64.charm
Packed jammy_ubuntu-22.04-amd64.charm
+ test -f jammy_ubuntu-22.04-amd64.charm
+ unzip -l jammy_ubuntu-22.04-amd64.charm
+ MATCH src/charm.py
grep error: pattern not found, got:
Archive:  jammy_ubuntu-22.04-amd64.charm
  Length      Date    Time    Name
---------  ---------- -----   ----
      271  2024-08-14 14:58   manifest.yaml
      156  2024-08-14 14:58   metadata.yaml
---------                     -------
      427                     2 files
-----
.
@lengau lengau added Bug Something isn't working triaged labels Aug 14, 2024
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/CRAFT-3238.

This message was autogenerated

@lengau lengau self-assigned this Aug 14, 2024
@lengau
Copy link
Collaborator Author

lengau commented Aug 14, 2024

pydantic 2 branch:

2024-08-14 15:37:07 Successful tasks: 40
2024-08-14 15:37:07 Aborted tasks: 1
2024-08-14 15:37:07 Failed tasks: 11
    - multipass:ubuntu-20.04-64:tests/spread/smoketests/basic:focal_bases
    - multipass:ubuntu-20.04-64:tests/spread/smoketests/basic:jammy_bases
    - multipass:ubuntu-20.04-64:tests/spread/smoketests/basic:noble_platforms
    - multipass:ubuntu-20.04-64:tests/spread/smoketests/metafiles-bad-yaml-unenforced
    - multipass:ubuntu-22.04-64:tests/spread/dependencies/requirements:basic
    - multipass:ubuntu-22.04-64:tests/spread/dependencies/requirements:hash
    - multipass:ubuntu-22.04-64:tests/spread/dependencies/requirements:hash_pydeps
    - multipass:ubuntu-22.04-64:tests/spread/dependencies/requirements:pydeps
    - multipass:ubuntu-22.04-64:tests/spread/smoketests/basic:focal_bases
    - multipass:ubuntu-22.04-64:tests/spread/smoketests/basic:jammy_bases
    - multipass:ubuntu-22.04-64:tests/spread/smoketests/metafiles-bad-yaml-unenforced
error: unsuccessful run

@lengau
Copy link
Collaborator Author

lengau commented Aug 16, 2024

Fixed in #1815

@lengau lengau closed this as completed Aug 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working triaged
Projects
None yet
Development

No branches or pull requests

1 participant