breaking(release_charm.yaml): Upload OCI resources from GHCR directly #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmcraft 2.7.0 contains a fix for multi-arch OCI images issue: canonical/charmcraft#1685 fix: canonical/charmcraft#1708 However, it fixes it in a "backwards-compatible" way—if the image is available locally, it will still upload it incorrectly. Stop downloading the image locally & always use GHCR so that charmcraft uploads the image correctly This will break on charmcraft < 2.7.0
|
charmcraft 2.7.0 is |
|
tested on canonical/postgresql-k8s-operator#490 |
carlcsaposs-canonical
requested review from
taurus-forever,
dragomirp and
marceloneppel
|
tested on single-arch charm: canonical/mysql-k8s-operator#437 |
marceloneppel
approved these changes
Jun 19, 2024
taurus-forever
approved these changes
Jun 19, 2024
carlcsaposs-canonical
referenced
this pull request
in canonical/mysql-router-k8s-operator
Jun 25, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [allure-pytest-collection-report](https://togithub.com/canonical/data-platform-workflows) | integration | major | `v13.3.4` -> `v16.2.0` | | [canonical/data-platform-workflows](https://togithub.com/canonical/data-platform-workflows) | action | major | `v13.3.4` -> `v16.2.0` | | [pytest-operator-cache](https://togithub.com/canonical/data-platform-workflows) | integration | major | `v13.3.4` -> `v16.2.0` | | [pytest-operator-groups](https://togithub.com/canonical/data-platform-workflows) | integration | major | `v13.3.4` -> `v16.2.0` | --- ### Release Notes <details> <summary>canonical/data-platform-workflows (allure-pytest-collection-report)</summary> ### [`v16.2.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.2.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.1.0...v16.2.0) ##### What's Changed - compatible(build_charm.yaml): Add GitHub auth to avoid ccc rate limit by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/202](https://togithub.com/canonical/data-platform-workflows/pull/202) **Full Changelog**: canonical/data-platform-workflows@v16.1.0...v16.2.0 ##### Migration instructions If you have a build wrapper in tox.ini, add `GH_TOKEN` to `pass_env` ```ini [testenv:build-{production,dev,wrapper}] ##### Wrap `charmcraft pack` pass_env = CI GH_TOKEN ``` Example: [https://github.com/canonical/pgbouncer-k8s-operator/pull/322](https://togithub.com/canonical/pgbouncer-k8s-operator/pull/322) ### [`v16.1.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.1.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.0.1...v16.1.0) ##### What's Changed - compatible(integration_test_charm.yaml): Grant full SSH access on Azure runners by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/200](https://togithub.com/canonical/data-platform-workflows/pull/200) **Full Changelog**: canonical/data-platform-workflows@v16.0.1...v16.1.0 ### [`v16.0.1`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.0.1) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v16.0.0...v16.0.1) ##### What's Changed - patch(integration_test_charm.yaml): Decrease bootstrap timeout by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/199](https://togithub.com/canonical/data-platform-workflows/pull/199) **Full Changelog**: canonical/data-platform-workflows@v16.0.0...v16.0.1 ### [`v16.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v16.0.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v15.0.0...v16.0.0) ##### What's Changed - breaking(release_charm.yaml): Upload OCI resources from GHCR directly by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/198](https://togithub.com/canonical/data-platform-workflows/pull/198) **Full Changelog**: canonical/data-platform-workflows@v15...v16.0.0 ### [`v15.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v15.0.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v14.1.0...v15.0.0) ##### What's Changed - breaking(integration_test_charm.yaml): Run arm64 tests on all events by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/196](https://togithub.com/canonical/data-platform-workflows/pull/196) **Full Changelog**: canonical/data-platform-workflows@v14...v15.0.0 ### [`v14.1.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v14.1.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v14.0.0...v14.1.0) ##### What's Changed - compatible(integration_test_charm.yaml): Switch arm64 to Azure-hosted runners by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/192](https://togithub.com/canonical/data-platform-workflows/pull/192) **Full Changelog**: canonical/data-platform-workflows@v14.0.0...v14.1.0 ### [`v14.0.0`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v14.0.0) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.7...v14.0.0) ##### What's Changed - breaking(integration_test_charm.yaml): Only run arm64 tests on `schedule` by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/188](https://togithub.com/canonical/data-platform-workflows/pull/188) **Full Changelog**: canonical/data-platform-workflows@v13...v14.0.0 ### [`v13.3.7`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.7) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.6...v13.3.7) ##### What's Changed - patch(\_sync_docs.yaml): Updated secret keys in usage docs by [@​a-velasco](https://togithub.com/a-velasco) in [https://github.com/canonical/data-platform-workflows/pull/189](https://togithub.com/canonical/data-platform-workflows/pull/189) **Full Changelog**: canonical/data-platform-workflows@v13.3.6...v13.3.7 ### [`v13.3.6`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.6) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.5...v13.3.6) ##### What's Changed - patch: Install python3-pip with `--no-install-recommends` by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/187](https://togithub.com/canonical/data-platform-workflows/pull/187) **Full Changelog**: canonical/data-platform-workflows@v13.3.5...v13.3.6 ### [`v13.3.5`](https://togithub.com/canonical/data-platform-workflows/releases/tag/v13.3.5) [Compare Source](https://togithub.com/canonical/data-platform-workflows/compare/v13.3.4...v13.3.5) ##### What's Changed - patch(integration_test_charm.yaml): Add missing link to Allure usage docs by [@​carlcsaposs-canonical](https://togithub.com/carlcsaposs-canonical) in [https://github.com/canonical/data-platform-workflows/pull/184](https://togithub.com/canonical/data-platform-workflows/pull/184) **Full Changelog**: canonical/data-platform-workflows@v13.3.4...v13.3.5 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/canonical/mysql-router-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNjkuMiIsInVwZGF0ZWRJblZlciI6IjM3LjQxMy4yIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Carl Csaposs <carl.csaposs@canonical.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
charmcraft 2.7.0 contains a fix for multi-arch OCI images issue: canonical/charmcraft#1685 fix: canonical/charmcraft#1708
However, it fixes it in a "backwards-compatible" way—if the image is available locally, it will still upload it incorrectly.
Stop downloading the image locally & always use GHCR so that charmcraft uploads the image correctly
This will break on charmcraft < 2.7.0