Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose the dashboard transformation logic as a script #283

Closed
lucabello opened this issue Dec 7, 2023 · 1 comment
Closed

Expose the dashboard transformation logic as a script #283

lucabello opened this issue Dec 7, 2023 · 1 comment

Comments

@lucabello
Copy link
Contributor

Could we stop forcing carrying over diffs for COS? I mean forking upstream dashboards to have Juju specific variables like $juju_model, $juju_model_uuid, $juju_application, $juju_unit makes sense to give a better visibility of Juju models. However, carrying over the diff just to replace a variable (${DS_PROMETHEUS} -> ${prometheusds}, $datasource -> ${prometheusds}) doesn't make much sense to me.

I don't think we have that option, unfortunately. If this isn't done, and there is no datasource in Grafana named whatever upstream expects it to be named, the dashboard won't work once Grafana loads it as nothing is available to load the data.

We try to identify datasources and replace them with the prometheus and loki charm datasources, but this isn't fool proof, which is why we ask the charm authors to name them correctly from the get-go.

Originally posted by @simskij in #274 (comment)

@lucabello
Copy link
Contributor Author

Closing this as we don't see it being useful!

@lucabello lucabello closed this as not planned Won't fix, can't repro, duplicate, stale Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant