-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature request: expose test actions to inherited layers #3
Comments
I'm not sure I fully understand this. Are you suggesting adding a "smoke test" action to the base layer that other layers could easily register tests for? Can you give some examples of the types of tests you are envisioning? Also, how does tox fit into the picture for a deployed service? |
I'm not fully up to speed on how |
Smoke tests to verify a deployment do seem useful, but I'm not sure that tox is the right approach, as it is very oriented to doing unit tests of Python code. In the big data charms, we have a few smoke test Juju actions and I could see creating a framework for having a single But then I start to wonder exactly what smoke tests could usefully be added by layers lower than the top-level charm layer? For example, how much could the apache-php layer usefully assert about the vanilla charm without specific knowledge of how the charm should respond and under what conditions? I think I just need more examples about what each layer could test. |
Agreed, we can close this for now, I need to actually do more testing of my charms to get a feel for where I'm getting hungup and how to improve it. |
Closing per last comment; re-open as necessary. |
Was thinking maybe having the ability to run simple tox tests on layers that inherit the base class without having to go through the whole amulet song and dance for simple isolated charm tests.
Something like
juju do service/0 tox
orjuju do service/0 tox -e checkservices
, etc.The text was updated successfully, but these errors were encountered: