Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use regular link from profile detail to instances with that profile #536

Merged
merged 1 commit into from
Nov 15, 2023
Merged

Use regular link from profile detail to instances with that profile #536

merged 1 commit into from
Nov 15, 2023

Conversation

edlerd
Copy link
Collaborator

@edlerd edlerd commented Nov 14, 2023 •
edited
Loading

Done

  • Use a regular link from profile detail page to the instance list
  • simplify the instance filters

QA

  1. Run the LXD-UI:
    • On the demo server via the link posted by @webteam-app below. This is only available for PRs created by collaborators of the repo. Ask @lorumic or @edlerd for access.
    • With a local copy of this branch, run as described here.
  2. Perform the following QA steps:
    • check link from profile detail page to instances in used by section
    • check instance filters above instance list (also with page reload)

@webteam-app
Copy link

Demo starting at https://lxd-ui-536.demos.haus

@edlerd edlerd requested a review from lorumic November 15, 2023 07:58
lorumic
lorumic reviewed Nov 15, 2023
View reviewed changes
src/pages/instances/InstanceSearchFilter.tsx Outdated Show resolved Hide resolved
src/util/instanceFilter.tsx Outdated Show resolved Hide resolved
lorumic
lorumic approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@lorumic lorumic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for applying the changes! 👍

@edlerd edlerd merged commit ad1c1c6 into canonical:main Nov 15, 2023
5 checks passed
@edlerd edlerd deleted the link-profile-instances branch November 15, 2023 15:16
@lorumic lorumic mentioned this pull request Nov 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lorumic lorumic lorumic approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@edlerd @webteam-app @lorumic