Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mir fatal errors when Firefox gets initial keyboard input #2272

Closed
wmww opened this issue Jan 7, 2022 · 1 comment · Fixed by #2273
Closed

Mir fatal errors when Firefox gets initial keyboard input #2272

wmww opened this issue Jan 7, 2022 · 1 comment · Fixed by #2273

Comments

@wmww
Copy link
Contributor

wmww commented Jan 7, 2022

To reproduce:

  • Open Mir
  • Open Firefox on Wayland in Mir
  • Press a key without unfocusing Firefox
Mir fatal error: Attempt to send keyboard event to wl_surface@25 even though it was not given keyboard focus
@wmww
Copy link
Contributor Author

wmww commented Jan 10, 2022

It appears the cause is that events happen in the following order:

  • Initial keyboard created
  • focus given to surface
  • new keyboard created (too late for input focus event)
  • keyboard event
  • 2nd keyboard panics because it has no input focus

@wmww wmww mentioned this issue Jan 10, 2022
Merged
@bors bors bot closed this as completed in 0033077 Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

WlKeyboard: use WlSeat::FocusListener for focus tracking canonical/mir
1 participant
@wmww