Documentation for Cluster feature #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
…eate Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Adapted it that the class directly exposes .members @Property of members with getter to _members did not work missing tests Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
Codecov Report
@@ Coverage Diff @@
## master #342 +/- ##
======================================
Coverage 96.8% 96.8%
======================================
Files 12 12
Lines 970 970
Branches 108 108
======================================
Hits 939 939
Misses 12 12
Partials 19 19
Continue to review full report at Codecov.
|
ajkavanagh
suggested changes
Dec 13, 2018
| @@ -63,7 +63,7 @@ def get(cls, client, server_name): | |||
|
|
|||
| @classmethod | |||
| def all(cls, client, *args): | |||
| """Get all certificates.""" | |||
| """Get all cluster members.""" | |||
There was a problem hiding this comment.
Oh, I missed this in my review on the code; good catch!
Signed-off-by: Felix Engelmann <fe-github@nlogn.org>
ajkavanagh
approved these changes
Dec 13, 2018
|
Thanks very much for the PR - good addition to the docs, and thanks for also 'code gardening' and filling out the docstring for the container's method. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the cluster is now upstream, some documentation on how to use it might be helpful