Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document and use the correct parallel build count envvars #4537

Closed
mr-cal opened this issue Jan 24, 2024 · 1 comment
Closed

Document and use the correct parallel build count envvars #4537

mr-cal opened this issue Jan 24, 2024 · 1 comment
Labels
enhancement New features or optimizations

Comments

@mr-cal
Copy link
Collaborator

mr-cal commented Jan 24, 2024

What needs to get done

  • fix the documentation
  • create the following logic:
  1. Snapcraft should use SNAPCRAFT_PARALLEL_BUILD_COUNT.
  2. If it is not set, use CRAFT_PARALLEL_BUILD_COUNT
  3. If it is not set, take the lesser of SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT and the total number of CPUs on the system.
    • If SNAPCRAFT_MAX_PARALLEL_BUILD_COUNT is not set, then use CRAFT_MAX_PARALLEL_BUILD_COUNT
  4. If neither MAX envvars are set and the number of CPUs on the system cannot be determined, default to 1.

Why it needs to get done

  1. Documentation is incomplete and unclear
  2. CRAFT_PARALLEL_BUILD_COUNT is not being read by any craft-parts
  3. SNAPCRAFT_PARALLEL_BUILD_COUNT is not being read for core22 and onwards
@mr-cal
Copy link
Collaborator Author

mr-cal commented Oct 21, 2024

This was closed even though we didn't add documentation. Documentation is now tracked under canonical/craft-application#540.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New features or optimizations
Projects
None yet
Development

No branches or pull requests

1 participant