Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ubuntu_service): Add generics for parameters #338

Merged
merged 1 commit into from
Nov 15, 2023
Merged

feat(ubuntu_service): Add generics for parameters #338

merged 1 commit into from
Nov 15, 2023

Conversation

spydon
Copy link
Contributor

@spydon spydon commented Nov 13, 2023

To avoid having dynamic for parameters.

@spydon spydon force-pushed the ubuntu_service/param-generics branch from b2e4418 to a473703 Compare November 13, 2023 15:11
d-loose
d-loose approved these changes Nov 15, 2023
View reviewed changes
Copy link
Member

@d-loose d-loose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner, thanks!

@spydon
Copy link
Contributor Author

spydon commented Nov 15, 2023

@d-loose the code coverage didn't really drop, it just thinks so because some line is on two lines now.
I lost my merge rights again, could you merge it? :)

@d-loose d-loose merged commit 762f05c into canonical:main Nov 15, 2023
12 of 13 checks passed
@github-actions github-actions bot mentioned this pull request Nov 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d-loose d-loose d-loose approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spydon @d-loose