Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Page fails if no guesses available #5

Open
teptec opened this issue Feb 14, 2022 · 1 comment
Open

Page fails if no guesses available #5

teptec opened this issue Feb 14, 2022 · 1 comment

Comments

@teptec
Copy link

teptec commented Feb 14, 2022

I'll leave this system in the state which breaks the page:
https://canonn-science.github.io/canonn-signals/index.html?system=660485314065

There are 9 bodies in the system. Three have biological signals.

I FSS'd the system then viewed the page. No potential biologicals were shown.
I then DSS'd body 3.
At this point the json for the system indicated one unknown biological signal on the planet and no guesses available:

image

On loading the page, console reported error, called sort on undefined:

image

That would be this code:

image

(I guess this is a side effect of reducing the number of false positives!)

@Elfener99
Copy link

This commit should fix it. Going to leave this issue open in case I broke something else with it though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants