Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event excludes ignoring a few #30

Closed
derrickmehaffy opened this issue Mar 26, 2019 · 3 comments
Closed

Event excludes ignoring a few #30

derrickmehaffy opened this issue Mar 26, 2019 · 3 comments
Assignees
Labels

Comments

@derrickmehaffy
Copy link
Contributor

What version are you running
Reporting on behalf of other users, but based on reports EDMC-Canonn.1.9.1

Describe the bug
Shutdown event is in the excludes list but is still being sent

To Reproduce
Example: https://api.canonn.tech:2083/reportevents?eventname=Shutdown

Expected behavior
Shutdown should not be sent to the CAPI as we don't need to store the data.

Screenshots
N/A

** Log Files **
No logs as this is reported from our side

Additional context
N/A

@NoFoolLikeOne
Copy link
Collaborator

Change the code to populate a local exclusions list and then when complete this can be copied to the cls.exclusions and this should prevent other threads from reading the data before it is complete.

@NoFoolLikeOne
Copy link
Collaborator

Need to update the exclusions spreadsheet

  • ShutDown -- listed as Shutdown in the sheet
  • Statistics -- contains player stats. We will want our own model for that

@NoFoolLikeOne
Copy link
Collaborator

I've only seen evidence of typos and missing events so far

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants