Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitignore inconsistencies #782

Closed
dvic opened this issue Nov 5, 2023 · 4 comments · Fixed by #792
Closed

gitignore inconsistencies #782

dvic opened this issue Nov 5, 2023 · 4 comments · Fixed by #792
Labels
bug Something isn't working

Comments

@dvic
Copy link

dvic commented Nov 5, 2023

what kind of gitignore parsing approach is being used? Because I'm seeing inconsistencies, for example:

this works:

/foo/bar/baz.txt
image

but this does not:

foo/bar/baz.txt
image

while git status is fine with both. Any idea?

@dvic dvic added the bug Something isn't working label Nov 5, 2023
@dvic
Copy link
Author

dvic commented Nov 5, 2023

I haven't checked explicitly, but this seems the only thing. At first I thought a gitignore file in the parent directory was not picked up, but the issue was the absent / in the gitignore file.

@Canop
Copy link
Owner

Canop commented Nov 5, 2023

Thanks for the report. Did you see inconsistencies other than this one (path not starting with a / but with several items) ?

@Canop
Copy link
Owner

Canop commented Nov 11, 2023

This should be fixed with #792. Tests would be welcome.

@dvic
Copy link
Author

dvic commented Nov 12, 2023

This should be fixed with #792. Tests would be welcome.

Works like a charm, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants