Allow user to delete the scenarios agents with it #1446
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| expect(unique_agent_ids).to eq([agents(:jane_rain_notifier_agent).id]) | ||
| end | ||
|
|
||
| it "returns not agents when all are also used in a different scenario" do |
|
Good idea! |
| <div class="modal-header"> | ||
| <button type="button" class="close" data-dismiss="modal"><span aria-hidden="true">×</span><span class="sr-only">Close</span></button> | ||
| <h4 class="modal-title"> | ||
| <% if scenario == @scenario %> |
There was a problem hiding this comment.
I think this works because in once case @scenario is nil? Might be clearer as if @scenario && scenario == @scenario
There was a problem hiding this comment.
True, it works because we only assign @scneario in the show page.
There was a problem hiding this comment.
Both are technically fine. I just thought testing @scenario might be clearer for readability. I don't feel strongly.
There was a problem hiding this comment.
Ah, I see you made the change 😄
|
Looks great! |
dsander
force-pushed
the
feature/scenario-deletion
branch
from
73a18bb
to
98fae41
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scenario delete button now opens a modal in which the user can choose if and how the scenarios agents should be deleted with it.
Thanks to kreuzwerker.de who are paying me to work on this in the context of the research project 'Digitale Kuratierungstechnologien' of which they are a part of.