DryRunMemory #1550
Merged
DryRunMemory #1550
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| :code => "Agent.check = function() { this.createEvent({ 'message': this.memory('fu') }); };", | ||
| } | ||
| } | ||
| agent = Agents::JavaScriptAgent.new(valid_params) |
There was a problem hiding this comment.
Something minor, you could do agent = Agent.build_for_type(Agents::JavaScriptAgent, users(:bob), memory: {fu: 'bar'}) to save a few lines.
|
Thanks @Enfop, looks good to me. I do not think there are negative effects for other agents, as I see it it only makes the dry-run match the actual run more closely. |
|
Makes sense to me too. I wonder if we should eventually allow you to edit the memory in the dry run UI. |
|
@cantino For advanced |
|
I'm going to go ahead and merge this. Thanks @Enfop! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the PR i try to fix #1538. The changes fix the issue but i'm not sure if other agents are affected in a negative way.