EventFormattingAgent: Provide access to upstream agent

[knu]

Excerpt from the commit log of e55bb4a:

With this enhancement you can, for example, embed the site URL in an
event created by WebsiteAgent by interpolating like
"{{agent.options.url}}", or add a message prefix depending on the type
of upstream agent using the "case" construct of Liquid.

I believe user cannot do harm via AgentDrop, but let me know if I'm missing something.

[coveralls]

Coverage decreased (-0.1%) when pulling f79e26d on knu:provide_access_to_agent into 67fcfef on cantino:master.

[coveralls]

Coverage decreased (-44.77%) when pulling 9823ac7 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[coveralls]

Coverage decreased (-0.0%) when pulling 9ab66aa on knu:provide_access_to_agent into 67fcfef on cantino:master.

[cantino]

Very interesting @knu! Do you think we should have specs on AgentDrop itself?

[knu]

Sure, added!

[coveralls]

Coverage increased (+0.03%) when pulling a799408 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[coveralls]

Coverage increased (+0.03%) when pulling 6c30b16 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[cantino]

Awesome, thanks. Do you think we should expose this anywhere we use interpolated in any Agent?

[knu]

Probably having an EventDrop that returns the payload + .agent for interpolation is the way to go. Let me try.

[coveralls]

Coverage increased (+0.11%) when pulling c1f114d on knu:provide_access_to_agent into 67fcfef on cantino:master.

[knu]

@cantino It's done! I'll be working on a hover-help for Options to explain Liquid interpolation.

[coveralls]

Coverage increased (+0.11%) when pulling 00514d2 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[coveralls]

Coverage increased (+0.09%) when pulling 307ef15 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[knu]

@cantino I think this is now in a good shape for merge, thanks for looking!

[coveralls]

Coverage increased (+0.03%) when pulling 8596bd0 on knu:provide_access_to_agent into 67fcfef on cantino:master.

[cantino]

Thanks @knu, this looks great. I'll review closely this weekend, deploy to my setup, and merge.

[cantino]

Merged @knu, thanks! Can you update the wiki in the Liquid article about this?

[cantino]

(Also, did you get the email I sent you to knu@idaemons.org?)

[knu]

@cantino Thanks for merging it! I guess skip_created_at also can be deprecated after adding created_at to EventDrop, so I'll try that later.

[knu]

@cantino I'm yet to locate your mail. Could you give me any of Message-Id/Date/From?

[cantino]

Odd. I'm happy to send it again. It's from andrew at andrewcantino.

Message-ID: <CALXA01RwqU5hz9Nni-BJqK7FqXAobCh4L-0WCu7Dtff4bzyB+w@mail.gmail.com>

[knu]

I successfully received the mail, for the record.

[knu]

@cantino I updated the wiki page, review appreciated!

[cantino]

Looks good! Would you mind adding an example configuration that shows accessing a property from the event and agent? Something like "{{ event.agent.title }}" right? (Or is it just {{ agent.title }}?)