fix(storage): uploadFile(...) causes NullPointerException on Andr…

…oid (#579)
capawesome-team · Mar 9, 2024 · 0abbb8d · 0abbb8d
1 parent 59fd3d0
commit 0abbb8d
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/.changeset/fair-vans-do.md b/.changeset/fair-vans-do.md
@@ -0,0 +1,5 @@
+---
+'@capacitor-firebase/storage': patch
+---
+
+fix(android): `uploadFile(...)` causes `NullPointerException`
diff --git a/...c/main/java/io/capawesome/capacitorjs/plugins/firebase/storage/FirebaseStorageHelper.java b/...c/main/java/io/capawesome/capacitorjs/plugins/firebase/storage/FirebaseStorageHelper.java
@@ -1,5 +1,6 @@
 package io.capawesome.capacitorjs.plugins.firebase.storage;
 
+import androidx.annotation.Nullable;
 import com.getcapacitor.JSObject;
 import com.google.firebase.storage.StorageMetadata;
 import java.util.Iterator;
@@ -8,7 +9,11 @@
 
 public class FirebaseStorageHelper {
 
-    public static StorageMetadata buildStorageMetadata(JSObject metadata) throws JSONException {
+    @Nullable
+    public static StorageMetadata buildStorageMetadata(@Nullable JSObject metadata) throws JSONException {
+        if (metadata == null) {
+            return null;
+        }
         String cacheControl = metadata.getString("cacheControl");
         String contentDisposition = metadata.getString("contentDisposition");
         String contentEncoding = metadata.getString("contentEncoding");