Use a sync.Pool for MultiSegmentArenas #350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While working on this, I caught a bug in the transport tests: the test assume that it is safe to call the ReleaseFunc returned from NewMessage multiple times, which was incidentally true before but undocmented. This patch documents this invariant, and also ensures that it holds even when release() actually does something with the arena.
|
Failure looks to be #349 again |
lthibault
previously approved these changes
Nov 27, 2022
lthibault
approved these changes
Nov 27, 2022
|
Failure looks like #349 again |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Superseeds #347. note that relative to #347 this does a bit more work in cleanup to make sure memory is properly zeroed and we don't mis-report the number of segments when we get a new arena, though these weren't caught in testing on the other PR.
Benchmark results are similar.
While working on this, I caught a bug in the transport tests: the test assume that it is safe to call the ReleaseFunc returned from NewMessage multiple times, which was incidentally true before but undocmented. This patch documents this invariant, and also ensures that it holds even when release() actually does something with the arena.