Fixed: crash in token field autocomplete.

Without this fix, the autocomplete field would try to select the CPNotFound index from time to time which has always been wrong but is now specifically an error in Cappuccino. The fix is to select nothing instead.
cappuccino · Feb 3, 2013 · 0f64616 · 0f64616
1 parent 49c52a0
commit 0f64616
Showing 1 changed file with 7 additions and 2 deletions.
diff --git a/AppKit/_CPAutocompleteMenu.j b/AppKit/_CPAutocompleteMenu.j
@@ -115,8 +115,13 @@ var _CPAutocompleteMenuMaximumHeight = 307;
 
 - (void)setIndexOfSelectedItem:(int)anIndex
 {
-    [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:anIndex] byExtendingSelection:NO];
-    [tableView scrollRowToVisible:anIndex];
+    if (anIndex == CPNotFound)
+        [tableView selectRowIndexes:[CPIndexSet indexSet] byExtendingSelection:NO];
+    else
+    {
+        [tableView selectRowIndexes:[CPIndexSet indexSetWithIndex:anIndex] byExtendingSelection:NO];
+        [tableView scrollRowToVisible:anIndex];
+    }
 }
 
 - (int)indexOfSelectedItem