CPSound supports play while loading #1345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch allow to send 'play' message before the sound is actually loaded (by remembering the play request and playing the sound when loaded if needed) this allow to do: ```objj var sound = [[CPSound alloc] initWithContentsOfURL:aSoundURL byReference:NO]; [sound play]; ```
aljungberg
added a commit
that referenced
this pull request
Aug 22, 2011
--- This patch allow to send play message before the sound is actually loaded (by remembering the play request and playing the sound when loaded if needed) this allows to do: ```objj var sound = [[CPSound alloc] initWithContentsOfURL:aSoundURL byReference:NO]; [sound play]; ```
|
Has this now offically been merged into the master and available for download? |
|
it's officially merged, and is available in the master git, and in the next cappuccino release. |
|
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch allow to send 'play' message before
the sound is actually loaded (by remembering the play request
and playing the sound when loaded if needed)
this allows to do: