Fixed: removeTableColumn does not removes column from tableColumns array #1939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously the tableView didn't correctly remove a given tableColumn. It was removed in the method load (who is called by the layoutSubviews). Now the tableColumns is removed before the layoutSubviews (as in cocoa). It fixed also another problem, before this fixe it wasn't possible to remove all of the columns of a tableView (the last column was always displayed). This is fixed also Fixes cappuccino#1913 You can test that with the app of t00f
|
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
|
-#new |
|
Milestone: Someday. Labels: #ready-to-commit, AppKit, bug. What's next? The changes for this issue are ready to be committed by a member of the core team. |
aljungberg
added a commit
that referenced
this pull request
Jun 12, 2013
Fixed: removeTableColumn does not removes column from tableColumns array
|
Merged. Thanks! milestone=0.9.7 |
ghost
assigned
|
Assignee: aljungberg. Milestone: 0.9.7. Labels: #fixed, AppKit, bug. What's next? This issue is considered successfully resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously the tableView didn't correctly remove a given tableColumn. It was removed in the method load (who is called by the layoutSubviews).
Now the tableColumns is removed before the layoutSubviews (as in cocoa).
It fixed also another problem, before this fixe it wasn't possible to remove all of the columns of a tableView (the last column was always displayed). This is fixed also
Fixes #1913
You can test that with the app of @t00f