Fixed: support for dates (CPDatePicker) in CPPredicateEditor #2054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this commit, row templates and views belo,ging to them were copied via archiving/unarchiving. This was causing problems when the view was not completely CPCoding compliant, like for CPDatePicker. With this commit, template views use CPCopying (-copy method) when available. Also added CPCopying for CPDatePicker as a category in CPPredicateEditor. Test: in CPPredicateEditorTest, on the right panel, choose a keypath, operator, and select 'Dates' in the popup for the right expression. Fixes cappuccino#2041
|
There are still some visual issues with CPDatePicker inside a CPRuleEditor but they are not regressions:
|
|
Cool :) Why did you create a CPDatePicker's category instead of adding the method in CPDatePicker.j ? |
|
Because in cocoa NSDatePicker (and NSControl in general) are not NSCopying compliant by default. It's an exception for CPPredicateEditor because CPDatePicker is embedded in it as the default UI for dates. |
primalmotion
added a commit
that referenced
this pull request
Feb 11, 2014
Fixed: support for dates (CPDatePicker) in CPPredicateEditor
|
+#fixed Thanks! |
|
Milestone: Someday. Label: #fixed. What's next? This issue is considered successfully resolved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, row templates and views belonging to them were copied via archiving/unarchiving.
This was causing problems when the view was not completely CPCoding compliant, like for CPDatePicker.
With this commit, template views use CPCopying (-copy method) when available.
Also added CPCopying for CPDatePicker as a category in CPPredicateEditor.
Test: in CPPredicateEditorTest, on the right panel, choose a keypath, operator, and select 'Dates' in the popup for the right expression.
Fixes #2041