Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NEW: Environment variable to disable CommonJS environement building #2242

Conversation

primalmotion
Copy link
Member

This patch allows user to disable the commonJS build phase by setting the system environement variable IGNORE_ENV_COMMONJS.

For instance export IGNORE_ENV_COMMONJS=1

I'm not sure why we are building this CommonJS environment. It's taking time and sometime prevent our build to work with random compilator error. This patch allows to deactivate it. (credits to @Dogild)

Anyone knows what CommonJS env is exactly?

This patch allows user to disable the commonJS build phase by setting the system environement variable IGNORE_ENV_COMMONJS.

For instance `export IGNORE_ENV_COMMONJS=1`
@cappbot cappbot added this to the Someday milestone Nov 1, 2014
@cappbot cappbot added the #new label Nov 1, 2014
@cappbot
Copy link

cappbot commented Nov 1, 2014

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@primalmotion
Copy link
Member Author

I meant "is it useful unless we are building cappuccino or a command tool?"

@Dogild
Copy link
Member

Dogild commented Nov 1, 2014

Question would be : does CommonJS still work ?

@primalmotion
Copy link
Member Author

No, It is needed to generate all sort of command lines tools cappuccino provides. But for an pure browser app, it seems to be unnecessary.

Antoine Mercadal

On Nov 1, 2014, at 08:51, Alexandre Wilhelm notifications@github.com wrote:

Question would be : does CommonJS still work ?


Reply to this email directly or view it on GitHub.

@ahankinson
Copy link
Contributor

-#new
+feature
+tools
+#needs-review

@cappbot
Copy link

cappbot commented Nov 1, 2014

Milestone: Someday. Labels: #needs-review, feature, tools. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on.

primalmotion added a commit that referenced this pull request Nov 5, 2014
…environement

NEW: Environment variable to disable CommonJS environement building
@primalmotion primalmotion merged commit d63669a into cappuccino:master Nov 5, 2014
@primalmotion
Copy link
Member Author

+#fixed

Works well and it's all optional anyway

@cappbot
Copy link

cappbot commented Nov 5, 2014

Milestone: Someday. Labels: #fixed, feature, tools. What's next? This issue is considered successfully resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants