-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NEW: Environment variable to disable CommonJS environement building #2242
NEW: Environment variable to disable CommonJS environement building #2242
Conversation
This patch allows user to disable the commonJS build phase by setting the system environement variable IGNORE_ENV_COMMONJS. For instance `export IGNORE_ENV_COMMONJS=1`
Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue. |
I meant "is it useful unless we are building cappuccino or a command tool?" |
Question would be : does CommonJS still work ? |
No, It is needed to generate all sort of command lines tools cappuccino provides. But for an pure browser app, it seems to be unnecessary. Antoine Mercadal
|
-#new |
Milestone: Someday. Labels: #needs-review, feature, tools. What's next? This issue is pending an architectural or implementation design decision and should be discussed or voted on. |
…environement NEW: Environment variable to disable CommonJS environement building
+#fixed Works well and it's all optional anyway |
Milestone: Someday. Labels: #fixed, feature, tools. What's next? This issue is considered successfully resolved. |
This patch allows user to disable the commonJS build phase by setting the system environement variable IGNORE_ENV_COMMONJS.
For instance
export IGNORE_ENV_COMMONJS=1
I'm not sure why we are building this CommonJS environment. It's taking time and sometime prevent our build to work with random compilator error. This patch allows to deactivate it. (credits to @Dogild)
Anyone knows what CommonJS env is exactly?