Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed: underscores missing when accessing CPColor's components ivar #2377

Closed

Conversation

daboe01
Copy link
Contributor

@daboe01 daboe01 commented Sep 2, 2015

previously, the ivar was erroneously accessed by the property name using dot syntax.
this is corrected by adding the underscore appropriately.
credits: https://groups.google.com/forum/?fromgroups#!topic/objectivej/DbHN1ffcjO0

@daboe01 daboe01 changed the title Fixed: underscores missing when accessing for CPColor's components ivar Fixed: underscores missing when accessing CPColor's components ivar Sep 2, 2015
@cappbot cappbot added this to the Someday milestone Sep 3, 2015
@cappbot cappbot added the #new label Sep 3, 2015
@cappbot
Copy link

cappbot commented Sep 3, 2015

Milestone: Someday. Label: #new. What's next? A reviewer should examine this issue.

@aparajita
Copy link
Contributor

Danke. You tested it?

@daboe01
Copy link
Contributor Author

daboe01 commented Sep 7, 2015

no.

maybe michael can test it in his app?

@michael:
you can download the fixed capp framework here:
https://github.com/daboe01/cappuccino/tree/fix-CGContextDrawRadialGradient

best greetings,
daniel

Am 07.09.2015 um 05:16 schrieb Aparajita Fishman notifications@github.com:

Danke. You tested it?


Reply to this email directly or view it on GitHub.

@cappbot
Copy link

cappbot commented Sep 16, 2015

Milestone: 0.9.9. Labels: #ready-to-commit, AppKit, bug. What's next? The changes for this issue are ready to be committed by a member of the core team.

@Dogild
Copy link
Member

Dogild commented Sep 22, 2015

More informations here : https://groups.google.com/forum/?fromgroups=#!topic/objectivej/DbHN1ffcjO0

The manual test CPGradientTest looks good with the current version ! This fix will work when using CPColor's array instead of using the method CGGradientCreateWithColorComponents() (which is how cocoa works)

@cappbot
Copy link

cappbot commented Sep 22, 2015

Milestone: 0.9.9. Labels: #needs-confirmation, AppKit, bug. What's next? This issue needs a volunteer to independently reproduce the issue.

@Dogild Dogild self-assigned this Sep 23, 2015
@cappbot
Copy link

cappbot commented Sep 23, 2015

Assignee: Dogild. Milestone: 0.9.9. Labels: #needs-confirmation, AppKit, bug. What's next? This issue needs a volunteer to independently reproduce the issue.

@Dogild
Copy link
Member

Dogild commented Oct 2, 2015

According to the Cocoa doc (https://developer.apple.com/library/mac/documentation/GraphicsImaging/Reference/CGGradient/#//apple_ref/c/func/CGGradientCreateWithColors), when using the gradient color you need to pass CGColor and not CPColor.

Everything looks good in the framework right now (manual test in CPGradientTest)

@cappbot
Copy link

cappbot commented Oct 2, 2015

Assignee: Dogild. Milestone: 0.9.9. Labels: #needs-confirmation, #works-for-me, AppKit, bug. What's next? Attempts to reproduce the problem described by this issue have failed to reveal any erroneous situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants