Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

M680X - remove unused s_cpu_type #1695

Merged
merged 1 commit into from
Oct 29, 2020
Merged

Conversation

XVilka
Copy link
Contributor

@XVilka XVilka commented Oct 13, 2020

If you compile capstone with -Werror warning enabled it produces the following error:

  CC      arch/M680X/M680XDisassembler.o
arch/M680X/M680XDisassembler.c:2124:20: error: variable 's_cpu_type' is not needed and will not be emitted [-Werror,-Wunneeded-internal-declaration]
static const char *s_cpu_type[] = {
                   ^
1 error generated.

Since s_cpu_type is not used anywhere in the next branch, it's safe to just remove it completely. It was used in the master branch only, albeit also unnecessary.

cc @trufae @ret2libc

@XVilka
Copy link
Contributor Author

XVilka commented Oct 20, 2020

@aquynh @catenacyber please take a look

@aquynh
Copy link
Collaborator

aquynh commented Oct 27, 2020

@aladur please ack.

@aladur
Copy link
Contributor

aladur commented Oct 28, 2020

s_cpu_type is not used and can be removed, commit is fine.
Thanks.

@aquynh aquynh merged commit c93fa3a into capstone-engine:next Oct 29, 2020
@aquynh
Copy link
Collaborator

aquynh commented Oct 29, 2020

merged, thanks!

@catenacyber
Copy link
Contributor

Always good to remove code :-)

@XVilka XVilka deleted the fix-warning branch October 30, 2020 13:12
kabeor added a commit that referenced this pull request Dec 2, 2021
kazarmy pushed a commit to rizinorg/capstone that referenced this pull request Dec 2, 2021
@riptl riptl mentioned this pull request Jul 22, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants