Use -Werror when building in CI #17781

ret2libc · 2020-10-12T09:26:48Z

Closing issues

Closes #17780

trufae · 2020-10-12T09:33:56Z

Will you fix the current warnings in this PR before merging it?

ret2libc · 2020-10-12T09:39:10Z

Will you fix the current warnings in this PR before merging it?

Yes sure, otherwise it would be red. Done.

XVilka · 2020-10-12T09:49:20Z

p/../arch/8051/8051_disas.c:64:14: error: ‘r_8051_disas’ defined but not used [-Werror=unused-function]
 static char *r_8051_disas(ut64 pc, const ut8 *buf, int len, int *olen) {
              ^~~~~~~~~~~~
cc1: all warnings being treated as errors
make[3]: *** [p/../arch/8051/8051_disas.o] Error 1

This reverts commit bd520b0.

codecov-io · 2020-10-12T11:17:30Z

Codecov Report

Merging #17781 into master will increase coverage by 0.00%.
The diff coverage is 53.84%.

@@           Coverage Diff           @@
##           master   #17781   +/-   ##
=======================================
  Coverage   40.19%   40.19%           
=======================================
  Files        1130     1130           
  Lines      357315   357313    -2     
=======================================
+ Hits       143616   143624    +8     
+ Misses     213699   213689   -10

Impacted Files	Coverage Δ
libr/asm/arch/tms320/c55x_plus/hashtable.c	`7.93% <ø> (ø)`
libr/bin/mangling/microsoft_demangle.c	`74.39% <ø> (-0.05%)`	⬇️
libr/io/io_desc.c	`69.76% <0.00%> (ø)`
libr/socket/run.c	`28.79% <ø> (ø)`
test/unit/test_pdb.c	`0.00% <ø> (ø)`
libr/anal/p/anal_mips_gnu.c	`29.51% <50.00%> (ø)`
libr/reg/profile.c	`71.95% <100.00%> (ø)`
libr/core/task.c	`61.22% <0.00%> (+2.67%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c89716...d69f4ff. Read the comment docs.

This reverts commit 226ad9b.

This reverts commit c487697.

XVilka · 2020-10-13T04:22:01Z

Should fix the capstone compilation error: capstone-engine/capstone#1695

ret2libc · 2020-10-13T07:42:21Z

Should fix the capstone compilation error: aquynh/capstone#1695

Until that is not merged, I removed the -Werror from acr builds (as those pass the cflags to capstone as well) so we can merge this and extend it once capstone fix lands upstream.

XVilka · 2020-10-13T08:10:22Z

Unrelated to this PR, but some useful warnings from MSVC:

c:\projects\radare2\libr\asm\arch\xtensa\gnu\xtensa-modules.c(4130): warning C4146: unary minus operator applied to unsigned type, result still unsigned [C:\projects\radare2\build\libr\anal\04634f8@@r_anal@sta.vcxproj]
c:\projects\radare2\libr\debug\p\debug_gdb.c(539): warning C4133: 'initializing': incompatible types - from 'RDebugReasonType (__cdecl *)(RDebug *,int)' to 'int (__cdecl *)(RDebug *,int)' [C:\projects\radare2\build\libr\debug\e931636@@r_debug@sta.vcxproj]
c:\projects\radare2\libr\debug\p\debug_native.c(1596): warning C4133: 'initializing': incompatible types - from 'RDebugReasonType (__cdecl *)(RDebug *,int)' to 'int (__cdecl *)(RDebug *,int)' [C:\projects\radare2\build\libr\debug\e931636@@r_debug@sta.vcxproj]
c:\projects\radare2\libr\debug\p\debug_winkd.c(268): warning C4133: 'initializing': incompatible types - from 'RDebugReasonType (__cdecl *)(RDebug *,int)' to 'int (__cdecl *)(RDebug *,int)' [C:\projects\radare2\build\libr\debug\e931636@@r_debug@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]
cl : Command line warning D9002: ignoring unknown option '-std=c99' [C:\projects\radare2\build\libr\core\f105261@@r_core@sta.vcxproj]

And some from clang-cl:

In file included from ../test/unit/test_r2r.c:3:
../test/unit/../../binr/r2r/r2r.c(117,6): warning: implicit declaration of function 'chdir' is invalid in C99 [-Wimplicit-function-declaration]
        if (chdir (abs_test_path) == -1) {
            ^
../test/unit/../../binr/r2r/r2r.c(259,7): warning: implicit declaration of function 'chdir' is invalid in C99 [-Wimplicit-function-declaration]
                if (chdir (r2r_dir) == -1) {
                    ^
In file included from ../test/unit/test_r2r.c:5:
../test/unit/../../binr/r2r/run.c(144,57): warning: passing 'char **' to parameter of type 'const char **' discards qualifiers in nested pointer types [-Wincompatible-pointer-types-discards-qualifiers]
        char *cmdline = r_str_format_msvc_argv (args_size + 1, argv);
                                                               ^~~~
..\libr\include/r_util/r_str.h(162,62): note: passing argument to parameter 'argv' here
R_API char *r_str_format_msvc_argv(size_t argc, const char **argv);
                                                             ^
In file included from ../test/unit/test_r2r.c:5:
../test/unit/../../binr/r2r/run.c(305,23): warning: passing 'unsigned char [1280]' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        r_str_remove_char (stdout_buf, '\r');
                                           ^~~~~~~~~~
..\libr\include/r_util/r_str.h(70,36): note: passing argument to parameter 'str' here
R_API void r_str_remove_char(char *str, char c);
                                   ^
In file included from ../test/unit/test_r2r.c:5:
../test/unit/../../binr/r2r/run.c(319,23): warning: passing 'unsigned char [1280]' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        r_str_remove_char (stderr_buf, '\r');
                                           ^~~~~~~~~~
..\libr\include/r_util/r_str.h(70,36): note: passing argument to parameter 'str' here
R_API void r_str_remove_char(char *str, char c);
                                   ^
In file included from ../test/unit/test_r2r.c:5:
../test/unit/../../binr/r2r/run.c(810,40): warning: expression result unused [-Wunused-value]
                                                for (; c = *cmds, c && c != '}'; *cmds++) {
                                                                                 ^~~~~~~
6 warnings generated.
In file included from ../libr/bin/mangling/cxx.c:5:
In file included from ..\libr\bin\mangling/./cxx/demangle.h:32:
..\libr\bin\mangling/./cxx/libiberty.h(342,9): warning: 'alloca' macro redefined [-Wmacro-redefined]
#define alloca(x) _alloca(x)
        ^
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt\malloc.h(176,13): note: previous definition is here
    #define alloca _alloca
            ^
1 warning generated.
[1016/1543] Compiling C object libr/bin/r_bin.dll.p/mangling_cxx_cp-demangle.c.obj
../libr/bin/mangling/cxx/cp-demangle.c(121,14): warning: incompatible redeclaration of library function 'alloca' [-Wincompatible-library-redeclaration]
extern char *alloca ();
             ^
../libr/bin/mangling/cxx/cp-demangle.c(121,14): note: 'alloca' is a builtin with type 'void *(unsigned long long)'
1 warning generated.
../libr/bin/pdb/pdb_downloader.c(34,9): warning: passing 'LPCWSTR' (aka 'const unsigned short *') to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
                free (origin);
                      ^~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt\corecrt_malloc.h(90,42): note: passing argument to parameter '_Block' here
    _Pre_maybenull_ _Post_invalid_ void* _Block
                                         ^
../libr/bin/pdb/pdb_downloader.c(35,9): warning: passing 'LPCWSTR' (aka 'const unsigned short *') to parameter of type 'void *' discards qualifiers [-Wincompatible-pointer-types-discards-qualifiers]
                free (dest);
                      ^~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\ucrt\corecrt_malloc.h(90,42): note: passing argument to parameter '_Block' here
    _Pre_maybenull_ _Post_invalid_ void* _Block
                                         ^
2 warnings generated.

../binr/r2r/run.c(144,57): warning: passing 'char **' to parameter of type 'const char **' discards qualifiers in nested pointer types [-Wincompatible-pointer-types-discards-qualifiers]
        char *cmdline = r_str_format_msvc_argv (args_size + 1, argv);
                                                               ^~~~
..\libr\include/r_util/r_str.h(162,62): note: passing argument to parameter 'argv' here
R_API char *r_str_format_msvc_argv(size_t argc, const char **argv);
                                                             ^
../binr/r2r/run.c(305,23): warning: passing 'unsigned char [1280]' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        r_str_remove_char (stdout_buf, '\r');
                                           ^~~~~~~~~~
..\libr\include/r_util/r_str.h(70,36): note: passing argument to parameter 'str' here
R_API void r_str_remove_char(char *str, char c);
                                   ^
../binr/r2r/run.c(319,23): warning: passing 'unsigned char [1280]' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
                        r_str_remove_char (stderr_buf, '\r');
                                           ^~~~~~~~~~
..\libr\include/r_util/r_str.h(70,36): note: passing argument to parameter 'str' here
R_API void r_str_remove_char(char *str, char c);
                                   ^
../binr/r2r/run.c(810,40): warning: expression result unused [-Wunused-value]
                                                for (; c = *cmds, c && c != '}'; *cmds++) {
                                                                                 ^~~~~~~
4 warnings generated.
[798/1543] Compiling C object test/unit/test_anal_block.exe.p/test_anal_block.c.obj
[799/1543] Compiling C object binr/r2r/r2r.exe.p/r2r.c.obj
../binr/r2r/r2r.c(117,6): warning: implicit declaration of function 'chdir' is invalid in C99 [-Wimplicit-function-declaration]
        if (chdir (abs_test_path) == -1) {
            ^
../binr/r2r/r2r.c(259,7): warning: implicit declaration of function 'chdir' is invalid in C99 [-Wimplicit-function-declaration]
                if (chdir (r2r_dir) == -1) {
                    ^
2 warnings generated.

XVilka · 2020-10-13T08:15:25Z

And one in WinDbg code cc @GustavoLCR @yossizap

../libr/debug/p/debug_windbg.c(74,10): warning: implicit declaration of function 'windbg_wait' is invalid in C99 [-Wimplicit-function-declaration]
                return windbg_wait (dbg, dbg->pid) != R_DEBUG_REASON_ERROR;
                       ^
../libr/debug/p/debug_windbg.c(82,25): warning: unused variable 'Qualifier' [-Wunused-variable]
        ULONG Id = tid, Class, Qualifier;
                               ^
../libr/debug/p/debug_windbg.c(82,18): warning: unused variable 'Class' [-Wunused-variable]
        ULONG Id = tid, Class, Qualifier;
                        ^
../libr/debug/p/debug_windbg.c(165,52): warning: incompatible pointer types passing 'int *' to parameter of type 'PULONG' (aka 'unsigned long *') [-Wincompatible-pointer-types]
                ITHISCALL (dbgSysObj, GetCurrentProcessSystemId, &dbg->pid);
                                                                 ^~~~~~~~~
../libr/debug/p/debug_windbg.c(27,88): note: expanded from macro 'ITHISCALL'
#define ITHISCALL(dbginterface, function, ...) THISCALL (idbg->dbginterface, function, __VA_ARGS__)
                                                                                       ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(26,93): note: expanded from macro 'THISCALL'
#define THISCALL(dbginterface, function, ...) dbginterface->lpVtbl->function (dbginterface, __VA_ARGS__)
                                                                                            ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(166,51): warning: incompatible pointer types passing 'int *' to parameter of type 'PULONG' (aka 'unsigned long *') [-Wincompatible-pointer-types]
                ITHISCALL (dbgSysObj, GetCurrentThreadSystemId, &dbg->tid);
                                                                ^~~~~~~~~
../libr/debug/p/debug_windbg.c(27,88): note: expanded from macro 'ITHISCALL'
#define ITHISCALL(dbginterface, function, ...) THISCALL (idbg->dbginterface, function, __VA_ARGS__)
                                                                                       ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(26,93): note: expanded from macro 'THISCALL'
#define THISCALL(dbginterface, function, ...) dbginterface->lpVtbl->function (dbginterface, __VA_ARGS__)
                                                                                            ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(220,40): warning: incompatible pointer types passing 'int *' to parameter of type 'volatile long *' [-Wincompatible-pointer-types]
                        b->internal = InterlockedIncrement (&bp_idx);
                                                            ^~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winnt.h(3019,50): note: passing argument to parameter 'Addend' here
    _Inout_ _Interlocked_operand_ LONG volatile *Addend
                                                 ^
../libr/debug/p/debug_windbg.c(248,39): warning: incompatible pointer types passing 'int *' to parameter of type 'PULONG' (aka 'unsigned long *') [-Wincompatible-pointer-types]
        THISCALL (bkpt, GetCurrentPassCount, &b->togglehits);
                                             ^~~~~~~~~~~~~~
../libr/debug/p/debug_windbg.c(26,93): note: expanded from macro 'THISCALL'
#define THISCALL(dbginterface, function, ...) dbginterface->lpVtbl->function (dbginterface, __VA_ARGS__)
                                                                                            ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(279,89): warning: incompatible pointer types passing 'int *' to parameter of type 'PULONG' (aka 'unsigned long *') [-Wincompatible-pointer-types]
        if (!idbg || !idbg->initialized || FAILED (ITHISCALL (dbgCtrl, GetActualProcessorType, &type))) {
                                                                                               ^~~~~
../libr/debug/p/debug_windbg.c(27,88): note: expanded from macro 'ITHISCALL'
#define ITHISCALL(dbginterface, function, ...) THISCALL (idbg->dbginterface, function, __VA_ARGS__)
                                                                                       ^~~~~~~~~~~
../libr/debug/p/debug_windbg.c(26,93): note: expanded from macro 'THISCALL'
#define THISCALL(dbginterface, function, ...) dbginterface->lpVtbl->function (dbginterface, __VA_ARGS__)
                                                                                            ^~~~~~~~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\shared\winerror.h(28988,32): note: expanded from macro 'FAILED'
#define FAILED(hr) (((HRESULT)(hr)) < 0)
                               ^~
8 warnings generated.
[664/1543] Compiling C object libr/debug/r_debug.dll.p/p_native_maps_windows_maps.c.obj
[665/1543] Compiling C object libr/core/r_core.dll.p/casm.c.obj
[666/1543] Compiling C object libr/debug/r_debug.dll.p/p_debug_winkd.c.obj
[667/1543] Compiling C object libr/debug/r_debug.dll.p/p_native_windows_windows_debug.c.obj
../libr/debug/p/native/windows/windows_debug.c(1482,34): warning: cast to 'HANDLE' (aka 'void *') from smaller integer type 'USHORT' (aka 'unsigned short') [-Wint-to-void-pointer-cast]
                if (w32_NtDuplicateObject (ph, (HANDLE)handle.Handle, GetCurrentProcess (), &dupHandle, 0, 0, 0)) {
                                               ^
1 warning generated.

../libr/socket/socket.c(304,56): warning: incompatible pointer types passing 'int *' to parameter of type 'const char *' [-Wincompatible-pointer-types]
                                ret = setsockopt (s->fd, IPPROTO_TCP, TCP_NODELAY, &flag, sizeof (flag));
                                                                                   ^~~~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winsock2.h(2131,51): note: passing argument to parameter 'optval' here
    _In_reads_bytes_opt_(optlen) const char FAR * optval,
                                                  ^
../libr/socket/socket.c(261,21): warning: unused variable 'sa' [-Wunused-variable]
        struct sockaddr_in sa;
                           ^
../libr/socket/socket.c(794,23): warning: passing 'unsigned char *' to parameter of type 'char *' converts between pointers to integer types with different sign [-Wpointer-sign]
        int r = recv (s->fd, buf, len, 0);
                             ^~~
C:\Program Files (x86)\Windows Kits\10\include\10.0.19041.0\um\winsock2.h(2004,78): note: passing argument to parameter 'buf' here
    _Out_writes_bytes_to_(len, return) __out_data_source(NETWORK) char FAR * buf,
                                                                             ^
3 warnings generated.

libr/socket/run.c

trufae · 2020-10-13T12:16:53Z

🎉

XVilka · 2020-10-14T02:59:41Z

It broke Capstone 3 builds. Maybe we should just silently skip instead of emitting a #warning?

FAILED: libr/asm/8a8d21f@@r_asm@sha/p_asm_m68k_cs.c.o 
gcc -Ilibr/asm/8a8d21f@@r_asm@sha -I. -I../ -I../libr/include -Ilibr/asm/../../shlr -I../libr/asm/../../shlr -I../libr/asm/arch/include -I../libr/asm/arch -I../libr/asm/arch/h8300 -I../libr/asm/arch/hexagon -I../libr/asm/arch/msp430 -I../libr/asm/arch/rsp -I../libr/asm/arch/mcore -I../libr/asm/arch/v850 -I../libr/asm/arch/propeller -I../libr/asm/arch/ebc -I../libr/asm/arch/cr16 -I../libr/asm/arch/8051 -I../libr/asm/arch/v810 -I../libr/asm/arch/or1k -I../shlr/spp -I../shlr/sdb/src -I../shlr/zip/zlib -I../shlr/capstone/include -I../shlr/java -fdiagnostics-color=always -pipe -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -g -fvisibility=hidden -Werror -fPIC -pthread -DR2_PLUGIN_INCORE=1 -MD -MQ 'libr/asm/8a8d21f@@r_asm@sha/p_asm_m68k_cs.c.o' -MF 'libr/asm/8a8d21f@@r_asm@sha/p_asm_m68k_cs.c.o.d' -o 'libr/asm/8a8d21f@@r_asm@sha/p_asm_m68k_cs.c.o' -c ../libr/asm/p/asm_m68k_cs.c
../libr/asm/p/asm_m68k_cs.c:14:2: error: #warning Cannot find capstone-m68k support [-Werror=cpp]
 #warning Cannot find capstone-m68k support
  ^~~~~~~
cc1: all warnings being treated as errors
[733/1528] Compiling C object 'libr/asm/8
``

ret2libc · 2020-10-14T06:07:47Z

We could try -Wno-cpp (C, Objective-C, C++, Objective-C++ and Fortran only) Suppress warning messages emitted by #warning directives. (according to GCC pages). I will do this in a separate pr.

Use -Werror when building in CI

b5c4bad

ret2libc requested a review from trufae as a code owner October 12, 2020 09:26

ret2libc requested a review from XVilka October 12, 2020 09:26

ret2libc marked this pull request as draft October 12, 2020 09:27

Remove existing warnings

8317ff8

Anton Kochkov and others added 5 commits October 12, 2020 18:05

Do not include C file in 8051 analysis plugin.

bd520b0

Fix unused vars warnings

a763d94

Revert "Do not include C file in 8051 analysis plugin."

9d2ab7b

This reverts commit bd520b0.

Set also for FreeBSD

c487697

Set also for OpenBSD

226ad9b

github-actions bot added infrastructure Issues related to the radare2/cutter infrastructure r2r Regression tests RAnal RBin labels Oct 12, 2020

ret2libc added 5 commits October 12, 2020 14:14

Use -Werror only in some builds and avoid unused fcn in MacOS

a9f1b40

Revert "Set also for OpenBSD"

80c82d8

This reverts commit 226ad9b.

Revert "Set also for FreeBSD"

9e0b916

This reverts commit c487697.

Fix ci.yml

d69f4ff

Do not compile restore_saved_fd on MacOS

3f37ced

Do not use -Werror on acr until capstone is fixed

8b353a5

XVilka approved these changes Oct 13, 2020

View reviewed changes

ret2libc marked this pull request as ready for review October 13, 2020 08:10

ret2libc requested review from condret and thestr4ng3r as code owners October 13, 2020 08:10

ret2libc requested review from wargio and yossizap as code owners October 13, 2020 08:10

wargio reviewed Oct 13, 2020

View reviewed changes

libr/socket/run.c Show resolved Hide resolved

ret2libc merged commit 741d22e into radareorg:master Oct 13, 2020

ret2libc mentioned this pull request Oct 14, 2020

Use -Wno-cpp to avoid errors on #warning #17785

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use -Werror when building in CI #17781

Use -Werror when building in CI #17781

ret2libc commented Oct 12, 2020

trufae commented Oct 12, 2020

ret2libc commented Oct 12, 2020

XVilka commented Oct 12, 2020

codecov-io commented Oct 12, 2020 •

edited

Loading

XVilka commented Oct 13, 2020

ret2libc commented Oct 13, 2020

XVilka commented Oct 13, 2020 •

edited

Loading

XVilka commented Oct 13, 2020 •

edited

Loading

trufae commented Oct 13, 2020

XVilka commented Oct 14, 2020

ret2libc commented Oct 14, 2020

Use -Werror when building in CI #17781

Use -Werror when building in CI #17781

Conversation

ret2libc commented Oct 12, 2020

trufae commented Oct 12, 2020

ret2libc commented Oct 12, 2020

XVilka commented Oct 12, 2020

codecov-io commented Oct 12, 2020 • edited Loading

Codecov Report

XVilka commented Oct 13, 2020

ret2libc commented Oct 13, 2020

XVilka commented Oct 13, 2020 • edited Loading

XVilka commented Oct 13, 2020 • edited Loading

trufae commented Oct 13, 2020

XVilka commented Oct 14, 2020

ret2libc commented Oct 14, 2020

codecov-io commented Oct 12, 2020 •

edited

Loading

XVilka commented Oct 13, 2020 •

edited

Loading

XVilka commented Oct 13, 2020 •

edited

Loading