Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for aarch64 distributions #1720

Merged
merged 1 commit into from
Mar 7, 2021

Conversation

urbas
Copy link

@urbas urbas commented Jan 23, 2021

It looks like manylinux1 does not seem to support aarch64 architectures (see the manylinux README). I'm getting this error when trying to install the wheel with pip:

ERROR: capstone-4.0.2-py3-none-manylinux1_aarch64.whl is not a supported wheel on this platform.

According to PEP 599 it seems like manylinux2014 is what should be used instead.

Here are logs from our failing build (in NixOS): https://hydra.nixos.org/build/134963890/nixlog/1/tail

@urbas
Copy link
Author

urbas commented Jan 31, 2021

cc: @aquynh

@emoon
Copy link
Contributor

emoon commented Jan 31, 2021

I'm not sure why I'm tagged for this PR. I'm maintaining the m68k backend.

@urbas
Copy link
Author

urbas commented Jan 31, 2021

I'm not sure why I'm tagged for this PR. I'm maintaining the m68k backend.

Apologies for that. Removed.

@urbas
Copy link
Author

urbas commented Feb 4, 2021

Btw, I verified this builds correctly on a Raspberry Pi 3 and 4 (64-bit).

@pranith
Copy link
Contributor

pranith commented Mar 4, 2021

Can you please create a new PR on libcapstone?

@aquynh aquynh merged commit 310e373 into capstone-engine:master Mar 7, 2021
@aquynh
Copy link
Collaborator

aquynh commented Mar 7, 2021

merged, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants