Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add general encoding information for instructions #2231

Closed
wants to merge 4 commits into from

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Jan 3, 2024

Adds the encoding information for each instruction. @AngelDev06 did the first implementation in #2045

This PR adds a few changes:

  • Rename ARM_MEM_FMT to something ISA or LLVM related. The current names are rather arbitrary and don't relate to the formatting as described in the ISA or LLVM definitions. Which makes it difficult to determine which encoding corresponds to which one in the ISA.

  • Add an enum for ISA instruction formats for ARM (if possible). According to C2.1 (document DDI0553B.v)

  • Generate for all other archs the encoding.

@Rot127
Copy link
Collaborator Author

Rot127 commented Jan 14, 2024

@AngelDev06 Any objections against this (cff87a3) naming convention?

@Rot127 Rot127 mentioned this pull request Jan 14, 2024
@AngelDev06
Copy link

@Rot127 None. I like it more than my version, which was a little rushed. It's better that you can now refer to the documentation rather than trying to make sense from comments.

@Rot127
Copy link
Collaborator Author

Rot127 commented Apr 22, 2024

Closed due to: #2045 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants