Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2234. #2236

Merged
merged 1 commit into from
Jan 14, 2024
Merged

Fix #2234. #2236

merged 1 commit into from
Jan 14, 2024

Conversation

Rot127
Copy link
Collaborator

@Rot127 Rot127 commented Jan 5, 2024

BL is no call and does not read SP

New output:

./cstool -d aarch64 "\xec\x6a\x01\x95"
 0  ec 6a 01 95  bl	0x405abb0
	ID: 81 (bl)
	op_count: 1
		operands[0].type: IMM = 0x405abb0
		operands[0].access: READ
	Registers modified: x30
	Groups: call branch_relative 

No test because we cannot test negative conditions with cstest (no SP read etc.).

@Rot127
Copy link
Collaborator Author

Rot127 commented Jan 5, 2024

@kabeor Please take a look at it. Its a simple one.

@Rot127 Rot127 marked this pull request as draft January 6, 2024 11:42
- BL, BLR don't read SP.
- Add branch flags.
@Rot127 Rot127 marked this pull request as ready for review January 13, 2024 14:05
@Rot127
Copy link
Collaborator Author

Rot127 commented Jan 13, 2024

@kabeor @find0x90 Take a look please.

@kabeor
Copy link
Member

kabeor commented Jan 14, 2024

👍

@kabeor kabeor merged commit 77710a8 into capstone-engine:next Jan 14, 2024
11 checks passed
@XVilka
Copy link
Contributor

XVilka commented Jan 14, 2024

@kabeor for some reason no labels were added, does auto-labeler action work? Maybe it requires to be enabled in the settings?

@Rot127
Copy link
Collaborator Author

Rot127 commented Jan 14, 2024

It does. Labels were added here: #2231

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants