Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

We need Error boundaries and need to handle exceptions #210

Closed
dahal opened this issue Mar 23, 2024 · 10 comments · Fixed by #242
Closed

We need Error boundaries and need to handle exceptions #210

dahal opened this issue Mar 23, 2024 · 10 comments · Fixed by #242
Labels
🚀 GOOD FIRST ISSUE Good for newcomers 🙏 NEED HELP Extra attention is needed

Comments

@dahal
Copy link
Contributor

dahal commented Mar 23, 2024

We need to render error pages for bunch of errors (404, 500 etc).

Also, let's implement sentry for exception notifications. We donot want to be vendor locked, so lets make sure that the code does not break if Sentry is not enabled.

@dahal dahal added 🚀 GOOD FIRST ISSUE Good for newcomers 🙏 NEED HELP Extra attention is needed labels Mar 23, 2024
Copy link

linear bot commented Mar 23, 2024

@Vinyl-Davyl
Copy link

Would like to work on this too

@dahal
Copy link
Contributor Author

dahal commented Mar 23, 2024

Would like to work on this too

Assigned 🚀

@dahal
Copy link
Contributor Author

dahal commented Mar 30, 2024

Due it inactivity, I am making it open for others to contribute. Please feel free to submit the PR.

@Pranavtej
Copy link

Pranavtej commented Mar 30, 2024

@dahal would like to work on this issue , please assign me

@Tarunkumartasets
Copy link

this is not_found page for 404
image
in next 14 we need to have each error.tsx as they have removed 500.tsx which was in page router

doubt's
@dahal should we make sentry integration optional
@dahal can I get some idea to standardised the way we show error in each pages
also do we need to add error boundary to each major component

progress
404 page is done
sentry integration is done

@dahal
Copy link
Contributor Author

dahal commented Mar 30, 2024

@Pranavtej looks like @Tarunkumartasets picked this up, we have other issues if any of it interests you 🙏🏼

@Tarunkumartasets for error pages, let's go with something simple, here is the mockup

404

@dahal
Copy link
Contributor Author

dahal commented Mar 30, 2024

@Tarunkumartasets

  • please make it optional
  • lets use the mockup above for all 404 pages
  • lets go with this approach

@Pranavtej
Copy link

@dahal that's ok i will pick some other issues .
if this issue still not resolved , assign to me

@DIWAKARKASHYAP
Copy link
Contributor

@dahal i raised this PR due it inactivity

@dahal dahal closed this as completed in #242 Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🚀 GOOD FIRST ISSUE Good for newcomers 🙏 NEED HELP Extra attention is needed
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants