Remove pinning of grpcio dependencies #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krithika369
commented
Nov 3, 2023
| @@ -122,7 +122,7 @@ def main(spec_path, spark): | |||
| .builder \ | |||
| .appName(args.job_name) \ | |||
| .getOrCreate() | |||
| spark.conf.set("spark.sql.execution.arrow.enabled", "true") | |||
| spark.conf.set("spark.sql.execution.arrow.pyspark.enabled", "true") | |||
There was a problem hiding this comment.
This is a small fix since spark.sql.execution.arrow.enabled option is now deprecated in favor of this.
krithika369
requested review from
ariefrahmansyah,
deadlycoconuts and
tkpd-hafizhan
ariefrahmansyah
approved these changes
Nov 3, 2023
|
Thanks for the quick review, @ariefrahmansyah ! Merging. |
5 tasks
krithika369
added a commit
that referenced
this pull request
Nov 3, 2023
<!-- Thanks for sending a pull request! Here are some tips for you: 1. Run unit tests and ensure that they are passing 2. If your change introduces any API changes, make sure to update the e2e tests 3. Make sure documentation is updated for your PR! --> **What this PR does / why we need it**: <!-- Explain here the context and why you're making the change. What is the problem you're trying to solve. ---> Follow up from #485 `grpcio-reflection` is needed as a dependency for the Pyfunc UPI server. Adding it back, without pinning the version. **Which issue(s) this PR fixes**: <!-- *Automatically closes linked issue when PR is merged. Usage: `Fixes #<issue number>`, or `Fixes (paste link of issue)`. --> Fixes # **Does this PR introduce a user-facing change?**: <!-- If no, just write "NONE" in the release-note block below. If yes, a release note is required. Enter your extended release note in the block below. If the PR requires additional action from users switching to the new release, include the string "action required". For more information about release notes, see kubernetes' guide here: http://git.k8s.io/community/contributors/guide/release-notes.md --> ```release-note Fix: Add back grpcio-reflection as a dependency ``` **Checklist** - [ ] Added unit test, integration, and/or e2e tests - [ ] Tested locally - [ ] Updated documentation - [ ] Update Swagger spec if the PR introduce API changes - [ ] Regenerated Golang and Python client if the PR introduce API changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
With #465, we no longer need to pin the
grpciorelated libraries, which will in turn constrain theprotobufdependencies.Which issue(s) this PR fixes:
Fixes #
Does this PR introduce a user-facing change?:
Checklist