Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add grpcio-reflection back to pyfunc server dependencies #486

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Add grpcio-reflection back to pyfunc server dependencies #486

merged 1 commit into from
Nov 3, 2023

Conversation

krithika369
Copy link
Collaborator

What this PR does / why we need it:

Follow up from #485

grpcio-reflection is needed as a dependency for the Pyfunc UPI server. Adding it back, without pinning the version.

Which issue(s) this PR fixes:

Fixes #

Does this PR introduce a user-facing change?:

Fix: Add back grpcio-reflection as a dependency

Checklist

  • Added unit test, integration, and/or e2e tests
  • Tested locally
  • Updated documentation
  • Update Swagger spec if the PR introduce API changes
  • Regenerated Golang and Python client if the PR introduce API changes

@ghost
Copy link

ghost commented Nov 3, 2023

👇 Click on the image for a new way to code review

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map legend

ariefrahmansyah
ariefrahmansyah approved these changes Nov 3, 2023
View reviewed changes
Copy link
Contributor

@ariefrahmansyah ariefrahmansyah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 🙏🏻

@krithika369 krithika369 merged commit 7cccb1f into main Nov 3, 2023
24 checks passed
@krithika369 krithika369 deleted the update_grpcio_requirement branch November 3, 2023 06:29
@krithika369 krithika369 mentioned this pull request Nov 9, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ariefrahmansyah ariefrahmansyah ariefrahmansyah approved these changes

@tkpd-hafizhan tkpd-hafizhan Awaiting requested review from tkpd-hafizhan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@krithika369 @ariefrahmansyah