-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): Upgrade UI dependencies #384
Open
ariefrahmansyah
wants to merge
23
commits into
main
Choose a base branch
from
upgrade-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
+ Coverage 62.27% 68.07% +5.79%
==========================================
Files 124 149 +25
Lines 9774 11809 +2035
==========================================
+ Hits 6087 8039 +1952
- Misses 2949 3032 +83
Partials 738 738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
June 28, 2024 04:17
55cb301
to
af1f1a8
Compare
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
July 4, 2024 06:21
7fbe71f
to
a7e507d
Compare
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
July 12, 2024 11:42
be4b671
to
51a67f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to what had been done in MLP caraml-dev/mlp#100 and in Merlin caraml-dev/merlin#591, this PR updates certain UI dependencies in Turing, most notably:
package.json
file to pin the engine to >=20.13.1)Other minor changes have also been made to the GitHub CICD files (more details are covered below and in the comments left on the diff itself).
Main Changes
GitHub Actions Updates
actions/upload-artifact
- from v2 to v4 since the former has already been deprecated since the 30th of June this yearactions/download-artifact
- from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action andupload-artifact
need to be compatible to work)actions/checkout
- from v3 to v4 since it's similarly done in the MLP repoactions/setup-go
- from v4 to v5 since it's similarly done in the MLP repo (also provides caching)actions/setup-python
- from v2 to v5 to keep it updated to the latest version (also provides caching)docker/login-action
- from v1 to v3 just to keep it updated to the latest versionjupyterhub/action-k8s-await-workloads
- from v1 to v3 just to keep it updated to the latest version