-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(ui): Upgrade UI dependencies #384
Open
ariefrahmansyah
wants to merge
23
commits into
main
Choose a base branch
from
upgrade-ui
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
42ea8ba
Upgrade UI deps
ariefrahmansyah 1a8348d
Update node version
deadlycoconuts fe97de5
Update js packages
deadlycoconuts a5497ba
Update turing github cicd file
deadlycoconuts d7eced4
Remove helm-chart release workflow
deadlycoconuts fca5044
Update ensembler job and service workflows
deadlycoconuts e801745
Update setup-python action in turing workflow
deadlycoconuts 85cf241
Make setup-go optional for certain test-e2e test runs
deadlycoconuts 1a8724a
Update python caching in go actions
deadlycoconuts cd3d4b6
Update cluster setup and publishing actions
deadlycoconuts 98eeb36
Update artifact uploading action
deadlycoconuts 6bb99dc
Remove unsupported conda cache type from ensembler job and service wo…
deadlycoconuts f5e57ce
Update docker login actions
deadlycoconuts 7788fbd
Update k8s await workloads action
deadlycoconuts 82bbb21
Add engines field in package.json
deadlycoconuts 1e76ba0
Update github workflow publish step to use local github file definition
deadlycoconuts 28b12a5
Temporarily remove tests before publishing
deadlycoconuts 9bd9150
Deprecate ReactDOM.render
deadlycoconuts debf3c1
Replace EuiLoadingContent with EuiSkeletonText
deadlycoconuts 9a11b87
Import queryString directly from package instead of individual functions
deadlycoconuts 22b08c5
Update imports from react-collapsed
deadlycoconuts 0530476
Fix all tables
deadlycoconuts 51a67f5
Remove deprecated table props
deadlycoconuts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -32,20 +32,17 @@ jobs: | |
working-directory: ./sdk | ||
steps: | ||
- name: Check out code | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
|
||
- name: Setup Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v2 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Cache pip dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.cache/pip | ||
key: | | ||
pip-${{ hashFiles('sdk/requirements.txt') }}-${{ hashFiles('sdk/requirements.dev.txt') }}-${{ matrix.python-version }} | ||
restore-keys: pip- | ||
cache: pip | ||
cache-dependency-path: | | ||
sdk/requirements.txt | ||
sdk/requirements.dev.txt | ||
engines/pyfunc-ensembler-service/requirements.dev.txt | ||
Comment on lines
+41
to
+45
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Example of the cache being restored successfully: https://github.com/caraml-dev/turing/actions/runs/9804032057/job/27071120655#step:3:22 |
||
|
||
- name: Install dependencies | ||
run: make setup | ||
|
@@ -65,7 +62,7 @@ jobs: | |
outputs: | ||
release-type: ${{ steps.release-rules.outputs.release-type }} | ||
steps: | ||
- uses: actions/checkout@v3 | ||
- uses: actions/checkout@v4 | ||
- id: release-rules | ||
uses: ./.github/actions/release-rules | ||
with: | ||
|
@@ -87,23 +84,20 @@ jobs: | |
environment: ${{ needs.release-rules.outputs.release-type == 'dev' && 'manual' || '' }} | ||
steps: | ||
- name: Check out code | ||
uses: actions/checkout@v3 | ||
uses: actions/checkout@v4 | ||
with: | ||
# fetch full history for a proper version number assignment | ||
fetch-depth: 0 | ||
|
||
- name: Setup Python | ||
uses: actions/setup-python@v2 | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: 3.8 | ||
|
||
- name: Cache pip dependencies | ||
uses: actions/cache@v2 | ||
with: | ||
path: ~/.cache/pip | ||
key: | | ||
pip-${{ hashFiles('sdk/requirements.txt') }}-${{ hashFiles('sdk/requirements.dev.txt') }} | ||
restore-keys: pip- | ||
cache: pip | ||
cache-dependency-path: | | ||
sdk/requirements.txt | ||
sdk/requirements.dev.txt | ||
engines/pyfunc-ensembler-service/requirements.dev.txt | ||
|
||
- name: Build | ||
working-directory: ./sdk | ||
|
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can now use the
cache-dependency-path
input to indicate files that should be cached instead of having to manually caching them using theactions/actions/cache
action. Theactions/cache
action has also been removed since it's no longer needed. This applies for all the updatedactions/setup-[go/node/python]
actions.This is similar done in the MLP PR https://github.com/caraml-dev/mlp/pull/100/files.
Example of the cache being restored successfully: https://github.com/caraml-dev/turing/actions/runs/9804032065/job/27071184098#step:3:68