Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failing CI #94

Merged
merged 1 commit into from
Oct 2, 2017
Merged

Fix failing CI #94

merged 1 commit into from
Oct 2, 2017

Conversation

andrewda
Copy link
Contributor

@andrewda andrewda commented Oct 2, 2017

Looks like 0c36521#diff-11a82058b621f771e497118318cf203fR75 introduced a tiny issue that Prettier didn't correct, so the CI is failing. A few open PR's already have this change, but in case those take a while to get merged in, this explicitly fixes it.

@yeskunall
Copy link
Contributor

This was fixed in #93 (I think, correct me if I'm wrong tho), but yeah in case that PR takes a while to merge, your change should effectively stop the build from failing.

@andrewda
Copy link
Contributor Author

andrewda commented Oct 2, 2017

@yeskunall Yep I believe it was. If that get merged in first, great!

@mfix22 mfix22 merged commit 38c8eff into carbon-app:master Oct 2, 2017
@andrewda andrewda deleted the fix-ci branch November 21, 2019 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants