-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(carbon): Upgrade carbon to 10.29/7.29 #2088
Conversation
chore(carbon): upgrade to the latest 10.26 and 7.26 version of carbon
Deploy preview for carbon-addons-iot-react ready! Built with commit 28c0ae8 https://deploy-preview-2088--carbon-addons-iot-react.netlify.app |
Signed-off-by: Kevin Perrine <kperrine@gmail.com>
It seems that 'Clear Selection' has not only been changed to 'Clear selection', but that there is a new id for i18n called 'clear.all'. This is the aria-label used on the 'x' buttons within the tag when clearing out all selections from table header filter ListBox.
Fixed by moving them from enzyme to testing-library and targeting the proper new elements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, this is good to go. All the stories look right (minus a few carbon ones that don't load now and didn't load before), and nothing jumped out at me on the relevant carbon changelogs.
This PR currently has a merge conflict. Please resolve this and then re-add the |
Closes #2073, #2059, #2057
Summary
-Cherry picked the merge commit from the previous attempt and fixed the css to prevent the CardEditor tabs from overflow scrolling
Change List (commits, features, bugs, etc)
// copied from #1943
// new
'Clear selection', but that there is a new id for i18n called 'clear.all'.
This is the aria-label used on the 'x' buttons within the tag when
clearing out all selections from table header filter ListBox.
Acceptance Test (how to verify the PR)