Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(carbon): Upgrade carbon to 10.29/7.29 #2088

Merged
merged 13 commits into from
Mar 10, 2021
Merged

chore(carbon): Upgrade carbon to 10.29/7.29 #2088

merged 13 commits into from
Mar 10, 2021

Conversation

kevinsperrine
Copy link
Collaborator

@kevinsperrine kevinsperrine commented Mar 3, 2021

Closes #2073, #2059, #2057

Summary

-Cherry picked the merge commit from the previous attempt and fixed the css to prevent the CardEditor tabs from overflow scrolling

Change List (commits, features, bugs, etc)
// copied from #1943

  • (*.story): remove any local stories that were pointing to Carbon component stories as they no longer can be imported downstream
  • *(.test) a few minor updates to testcases to handle new version of Carbon, for one any component rendering a Tab needs to mock the scrollIntoView dom method, need to workaround the double call onChange bug in TableToolbarSearch
  • (*.storyshots): it seems like they've removed the tabIndex = 0 by default from buttons
    // new
  • fixed css on CardEditor to prevent the tabs from overflow scrolling
  • chore(carbon): upgrade to 10.29/7.29
  • chore(carbon): add new storyshots
  • chore(carbon): placeHolderText is deprecated for placeholder for search
  • chore(carbon): fix table tests related to 'Clear Selection'
    • It seems that 'Clear Selection' has not only been changed to
      'Clear selection', but that there is a new id for i18n called 'clear.all'.
      This is the aria-label used on the 'x' buttons within the tag when
      clearing out all selections from table header filter ListBox.
  • chore(carbon): fix SuiteHeaderLogoutModal test

Acceptance Test (how to verify the PR)

  • Regression test the existing storybook stories to make sure they still function correctly

@kevinsperrine kevinsperrine changed the title Fix hotspot editor chore(carbon): Upgrade carbon to 10.29/7.29 Mar 3, 2021
@netlify
Copy link

netlify bot commented Mar 3, 2021

Deploy preview for carbon-addons-iot-react ready!

Built with commit 28c0ae8

https://deploy-preview-2088--carbon-addons-iot-react.netlify.app

Signed-off-by: Kevin Perrine <kperrine@gmail.com>
It seems that 'Clear Selection' has not only been changed to
'Clear selection', but that there is a new id for i18n called 'clear.all'.
This is the aria-label used on the 'x' buttons within the tag when
clearing out all selections from table header filter ListBox.
Fixed by moving them from enzyme to testing-library and targeting
the proper new elements
Copy link
Contributor

@scottdickerson scottdickerson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@jkeen jkeen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I can tell, this is good to go. All the stories look right (minus a few carbon ones that don't load now and didn't load before), and nothing jumped out at me on the relevant carbon changelogs.

@kodiakhq
Copy link
Contributor

kodiakhq bot commented Mar 9, 2021

This PR currently has a merge conflict. Please resolve this and then re-add the status: ready to merge 🎉 label.

@kodiakhq kodiakhq bot merged commit fb59f1a into next Mar 10, 2021
@kodiakhq kodiakhq bot deleted the fix-hotspot-editor branch March 10, 2021 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Repo] Re-open Carbon upgrade PR
5 participants