Table last column border is missing

[stanislavgeorgiev]

This behavior can been seen in both my project and the library storybook:

It is caused by having an additional column automatically added by the table component itself:

<th [ngStyle]="{'width': scrollbarWidth + 'px', 'padding': 0, 'border': 0}">
	<!--
		Scrollbar pushes body to the left so this header column is added to push
		the title bar the same amount and keep the header and body columns aligned.
	-->
</th>

[zvonimirfras]

This is related to sticky header scrollbar issues.

The correct solution right now seems to be to make a change in carbon components styles to apply the border on thead instead of the last th. Especially since sticky headers is a feature that we would, ideally, support.

[stanislavgeorgiev]

We're definitely going to need the sticky headers even though probably will have to do a custom implementation of it since we have very specific requirements. I think the temp solution for now should be to add a parameter that would turn off that additional column. I have a "no data" card below my table and the width of the table and the card do not align:  Cheers, Stan.

…

On Wed, Sep 12, 2018 at 1:14 PM Zvonimir Fras ***@***.***> wrote: This is related to sticky header scrollbar issues. The correct solution right now seems to be to make a change in carbon components styles to apply the border on thead instead of the last th. Especially since sticky headers is a feature that we would, ideally, support. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#54 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABMgXfAaGuxFbluocKRrA2__lju7mfS9ks5uaUD_gaJpZM4WjhHU> .

[zvonimirfras]

@stanislavgeorgiev your image doesn't show for me here.

[stanislavgeorgiev]

Thanks @zvonimirfras, I reattached it to the post above. I attached it in my email reply but I guess github couldn't retrieve it from there.

[stanislavgeorgiev]

The other really annoying side effect from that hidden column is that my table ends up not centred in its box - left side is ok but there's more empty space on the right.

[stanislavgeorgiev]

Submitted a new issue with carbon-components:
carbon-design-system/carbon#1124

[stanislavgeorgiev]

@zvonimirfras I'm closing the issue since carbon-components@9.30.2 fixes the styles

[stanislavgeorgiev]

On a second thought, we should adopt the dependency update first - it's currently using 9.20.0. Could you bump it up to 9.30.2. I already switched it in our project but I'm scared to do it here :D

[zvonimirfras]

Bumped to latest in dev dependencies. 👍