Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Data Table header last column border is missing when there's a hidden column #1124

Closed
stanislavgeorgiev opened this issue Sep 19, 2018 · 1 comment
Closed

Data Table header last column border is missing when there's a hidden column #1124

stanislavgeorgiev opened this issue Sep 19, 2018 · 1 comment
Labels
severity: 3 https://ibm.biz/carbon-severity type: bug 🐛

Comments

@stanislavgeorgiev
Copy link
Contributor

Detailed description

Describe in detail the issue you're having.

I'm using the carbon-angular-components project and their implementation of Data Table has a hidden column at the end of the <thead><tr> section which results in a missing right border for the header row (see screenshot below)

Is this issue related to a specific component?

Data Table

What did you expect to happen? What happened instead? What would you like to see changed?

The css style could be improved to handle that case by updating

.bx--data-table-v2 th:last-of-type {
   border-right: 1px solid #dfe3e6;
}

to

.bx--data-table-v2 thead {
   border-right: 1px solid #dfe3e6;
}

What version of the Carbon Design System are you using?
9.12.0

Additional information

  • Screenshots or code
    image
@stanislavgeorgiev stanislavgeorgiev mentioned this issue Sep 19, 2018
Closed
@alisonjoseph alisonjoseph added type: bug 🐛 severity: 4 https://ibm.biz/carbon-severity severity: 3 https://ibm.biz/carbon-severity and removed severity: 4 https://ibm.biz/carbon-severity labels Sep 20, 2018
@zvonimirfras zvonimirfras mentioned this issue Oct 2, 2018
Closed
@aledavila aledavila mentioned this issue Oct 17, 2018
Merged
@carbon-bot
Copy link
Contributor

🎉 This issue has been resolved in version 9.30.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

joshblack pushed a commit to joshblack/carbon that referenced this issue May 2, 2019
@emyarod @joshblack
fix(Modal): add support for primary focus selector prop (carbon-desig…
3bc0c37 
…n-system#1124)

* fix(Modal): add support for primary focus selector prop

* docs(ModalWrapper): add example of `selectorPrimaryFocus` in use

* refactor(Modal): rename parameter to be in line with current convention

* chore(ModalWrapper): update snapshot
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
severity: 3 https://ibm.biz/carbon-severity type: bug 🐛
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@stanislavgeorgiev @alisonjoseph @carbon-bot