Skip to content

Commit

Permalink
fix: cv-dropdown v-model does not clear caption when set to empty
Browse files Browse the repository at this point in the history
  • Loading branch information
davidnixon committed Mar 30, 2024
1 parent dd069f4 commit b01cf04
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 0 deletions.
6 changes: 6 additions & 0 deletions src/components/CvDropdown/CvDropdown.stories.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -129,14 +129,20 @@ const vmodelTemplate = `
<cv-dropdown-item value="mysterious">The Armorer</cv-dropdown-item>
<cv-dropdown-item value="bounty-hunter">Greef Karga</cv-dropdown-item>
</cv-dropdown>
<div style="margin-top:2rem; background-color: #888888; padding:1rem">
<div>V-Model value: {{ myValue }}</div>
<select v-model="myValue">
<option value="mando">Mandalorian</option>
<option value="nite-owl">Bo-Katan</option>
<option value="baby-yoda">Grogu</option>
<option value="mysterious">Armorer</option>
<option value="bounty-hunter">Karga</option>
<option value="none">None</option>
</select>
<div>
<button @click="myValue = undefined">Clear value</button>
</div>
</div>
</div>
`;
const skeletonTemplate = `
Expand Down
1 change: 1 addition & 0 deletions src/components/CvDropdown/CvDropdown.vue
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,7 @@ watch(
() => props.modelValue,
() => {
dataValue.value = props.modelValue;
dataCaption.value = undefined;
}
);
watch(dataValue, () => {
Expand Down

0 comments on commit b01cf04

Please sign in to comment.