Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(storybook): brandUrl point to main root #1586

Merged

Conversation

benceszenassy
Copy link
Contributor

What did you do?

Updated storybook brandUrl.

Why did you do it?

It still pointed to packages/v3, but v3 is in root now.

How have you tested it?

Build storybook locally, and clicked the brand name

Were docs updated if needed?

  • N/A
  • No
  • Yes

@benceszenassy
Copy link
Contributor Author

hi @davidnixon,
if i run yarn lint on the code base, i get 315 files modified, these modifications contains only line endings (crlf -> lf). this is a valid result of the command? (i did not committed these changes)

its requested by

Delete eslintprettier-vue/prettier

@davidnixon
Copy link
Collaborator

hi @davidnixon, if i run yarn lint on the code base, i get 315 files modified, these modifications contains only line endings (crlf -> lf). this is a valid result of the command? (i did not committed these changes)

its requested by

Delete eslintprettier-vue/prettier

I see:

yarn lint
 DONE  No lint errors found!

I think is windows:
https://eslint.org/docs/latest/rules/linebreak-style#:~:text=The%20linebreaks%20(new%20lines)%20used,n%22%20for%20(CRLF).
Maybe setting this flag explicitly fixes this on windows?

Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@OlkaB approved

@kodiakhq kodiakhq bot merged commit 8217814 into carbon-design-system:main Apr 11, 2024
5 checks passed
@benceszenassy benceszenassy deleted the fix/storybook-brandurl branch May 25, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants