-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Port CvButtonSkeleton to Vue3 #1470
feat: Port CvButtonSkeleton to Vue3 #1470
Conversation
…into task/CvButtonSkeleton
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow! Thanks for helping out here! Almost perfect. the only thing I see is that CvButtonSkeleton
is imported in index.js
but not exported. So for me I see nothing in the story and I see this in the console log:
[Vue warn]: Failed to resolve component: cv-button-skeleton
and a blank story
When I add skeleton to the export like:
export {
CvButton,
CvButtonConsts,
CvButtonSet,
CvIconButton,
CvButtonSkeleton,
};
Extra
For bonus points, since you are in that code anyway, ... could I ask for a separate fix unrelated to skeleton?
The main button stories are in src/components/CvButton/CvButton.stories.js
but some of them have an issue. The button is blank like this:
The issue is that somehow we have
'slotArgs.default': 'Field size',
instead of
default: 'Field size',
Could you update the button stories to fix that too?
Thanks @davidnixon . Export added (sorry missed that). btw. As I'm not using github for PRs on a daily basis let me please know if I should do sth here (differently?) |
import CvButtonSkeleton from '../CvButtonSkeleton.vue'; | ||
|
||
describe('CvButtonSkeleton', () => { | ||
test.each([[undefined], [''], ['default']])( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not used that test.each
pattern before. Very cool!
Contributes to #1469
## What did you do?
Port CvButtonSkeleton to Vue3
## Why did you do it?
Hope this will help to finish transition before Vue2 EOL
How have you tested it?
please see CvButtonSkeleton.spec.js + CvButtonSkeleton.stories.js
compared behaviours with Vue2 storybook
Were docs updated if needed?