-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: cv-file-uploader docs enhancements #1520
docs: cv-file-uploader docs enhancements #1520
Conversation
d9d685f
to
0cb587e
Compare
Hi, @davidnixon . Forgive me, again, for the tardiness. I need your feedback on a few things:
|
dc91587
to
7d1dfe8
Compare
Hi, @davidnixon, just a friendly reminder about the points I need your input ☝️ |
@felipebritor oh sorry totally missed this. I will update today! |
This looks right to me. I know some changes cause the storybook to reload but I'm not sure why. I thought I might take a closer look at it Storybook 7.
The clear: {
control: 'none',
type: 'function',
table: {
type: { summary: '() => void' },
category: 'exposed methods',
},
description: 'Clear file list',
},
I think it should be like the react storybook. Only 1 icon is allowed. |
The Template function is called on state/args changes, making the file list reset. This external array will help us keep it persisted during the user session
This is a fragile **workaround** to customize new storybook controls. Currently, storybook lack the option to create customizable controls, as an option for knobs. This hack allow us to define our own control types, that should be defined at `window["STORYBOOK_CUSTOM_CONTROLS"]`, created at manager.js. This solution, along with the button control defined at manager.js, was found in a discussion about a new button control type: storybookjs/storybook#11971 (comment)
'uploading' state was 'loading'
7d1dfe8
to
ab26bda
Compare
The state icon displays as follows now: - Either display one of the states & removable ("edit" state in react) - Only show state if file is not set as invalid (unlike react, but let it consistent)
ab26bda
to
ff4241f
Compare
Done at ff4241f 👍 |
Contributes to #1519
What did you do?
Set '.jpg, .png' as initial values for(fix: cv-fileuploader - doc updates, disabled & initialStateUploading props and bug fixes #1529)accept
prop, so users can check invalid state right awayUpdate button story label to better translate its state(fix: cv-fileuploader - doc updates, disabled & initialStateUploading props and bug fixes #1529)Why did you do it?
How have you tested it?
Were docs updated if needed?