Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow menu dropdown placement and position #1525

Merged
merged 2 commits into from
Sep 11, 2023
Merged

fix: overflow menu dropdown placement and position #1525

merged 2 commits into from
Sep 11, 2023

Conversation

OlkaB
Copy link
Contributor

@OlkaB OlkaB commented Sep 7, 2023

Contributes to #1524

## What did you do?
Fixed placement and position for cv-overflow-menu so it will behave as in Vue2 (the menu's dropdown is appended to document.body)

Were docs updated if needed?

  • Yes

@OlkaB OlkaB marked this pull request as ready for review September 7, 2023 09:41
@OlkaB
Copy link
Contributor Author

OlkaB commented Sep 7, 2023

@davidnixon If the new placement of the menu was intentional - please discard this PR. In such case, the issue still would need a different fix (potentially it might be the one mentioned in the ticket #1524 comment, but haven't tested it widely)

Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@davidnixon davidnixon merged commit b1d21d8 into carbon-design-system:vNext Sep 11, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants