Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CvTag / CvTagSkeleton changes #1528

Merged
merged 6 commits into from
Sep 18, 2023

Conversation

caioafc
Copy link
Contributor

@caioafc caioafc commented Sep 13, 2023

Contributes to #1526

What did you do?

CvTag changes

  • Added small property to change component size (chosen small instead size because is the only available option for this component)

  • Created end tag for skeleton div, <div/> is not the best option

  • Reorganized initial tagClasses, we doesn't need to set kind classes when skeleton component is being used

  • Set label on Skeleton scenario in the Storybook (fixing console warn above)
    image

CvTagSkeleton

  • Created CvTagSkeleton for migration purposes by having a separated component to use Skeleton (preserving Vue 2 pattern)

How have you tested it?

  • Created unit tests
  • Checked Storybook behaviors and it's console

Were docs updated if needed?

  • N/A
  • No
  • Yes

@caioafc caioafc changed the title CvTag / CvTagSkeleton changes feat: CvTag / CvTagSkeleton changes Sep 13, 2023
/**
* tag size small
*/
small: Boolean,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Collaborator

@davidnixon davidnixon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm. thanks!

@davidnixon davidnixon merged commit 6341a17 into carbon-design-system:vNext Sep 18, 2023
5 of 6 checks passed
@caioafc caioafc deleted the feat-cv-tag-skeleton branch September 19, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants