fix: CvDataTable did not properly store/emit sort events #1543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was broken?
Clicking on a sortable header in a CvDataTable (e.g. the first two columns in the official story book didn't actually trigger the expected events:
order: undefined
Why ?
The code that emits
cv:sort
when clicking on aCvDataTableHeading
uses the keyvalue
:However, the receiving code destructs
payload
into a variable namedval
:As
val
doesn't acutally exist in the payload, the variable gets initialized toundefined
, breaking the rest of that function.What did you do?
Changed the code in
onSort(payload)
to use the variable namedvalue
instead ofval
.How have you tested it?
onSort
action now has the properorder
Were docs updated if needed?