Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cv-progress-skeleton): add initial implementation #1546

Conversation

mateusbandeiraa
Copy link
Contributor

@mateusbandeiraa mateusbandeiraa commented Oct 19, 2023

Contributes to #167

## What did you do?
Implemented cv-progress-skeleton.

## Why did you do it?
Because Carbon Vue rocks 😄 . And it was requested on #167.

How have you tested it?

Ran the existing unit tests and added new ones.

Were docs updated if needed?

  • N/A
  • No
  • Yes

@mateusbandeiraa
Copy link
Contributor Author

There's an annoying bug on this implementation that I temporarily fixed in an ugly way-- I don't even know if this could be
merged like this.

The label skeletons are not vertically aligned with the circle icons.
image

But the current React implementation looks good:
image

It looks like a bug on carbon-components that was fixed on version v11.38.0:
carbon-design-system/carbon@abff3a5#diff-275e913cf6a488e64f5011914882d9af6e9b614c918bb82f81990c7d3e147fd2L27-R27

I "fixed" it on my side by adding this style (not included on the PR):

<style scoped>
.bx--progress--vertical .bx--progress-label {
  margin-block-start: 0;
}
</style>

@davidnixon
Copy link
Collaborator

I think this is OK as-is. When we upgrade the components to Carbon 11 the alignment will get fixed.

@mateusbandeiraa mateusbandeiraa marked this pull request as ready for review October 28, 2023 18:17
@mateusbandeiraa
Copy link
Contributor Author

Alright. Marked as ready for review.

@kodiakhq kodiakhq bot merged commit 5c59c5b into carbon-design-system:main Nov 1, 2023
6 checks passed
@mateusbandeiraa mateusbandeiraa deleted the cv-progress-indicator-skeleton branch June 10, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants